You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/24 16:28:02 UTC
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #18752: Fix linalg_potri and linalg_potrf operators for large tensor.
josephevans commented on a change in pull request #18752:
URL: https://github.com/apache/incubator-mxnet/pull/18752#discussion_r460159278
##########
File path: tests/nightly/test_large_array.py
##########
@@ -1167,6 +1168,32 @@ def check_correctness(mxnet_op, numpy_op, atol=1e-3):
check_gather()
check_binary_broadcast()
+def test_linalg():
+ def check_potrf():
+ # creating an identity matrix input
+ A = nd.zeros((LARGE_SQ_X, LARGE_SQ_X))
+ for i in range(LARGE_SQ_X):
+ A[i,i] = 1
+
+ out = nd.linalg.potrf(A)
+ # output should be an identity matrix
+ for i in range(LARGE_SQ_X):
+ assert out[i,i] == 1
+
+ def check_potri():
+ # creating an identity matrix input
+ A = nd.zeros((LARGE_SQ_X, LARGE_SQ_X))
+ for i in range(LARGE_SQ_X):
+ A[i,i] = 1
+
+ out = nd.linalg.potri(A)
+ # output should be an identity matrix
+ for i in range(LARGE_SQ_X):
Review comment:
I'll refactor this with a follow-up PR that includes backwards tests.
##########
File path: tests/nightly/test_large_array.py
##########
@@ -1167,6 +1168,32 @@ def check_correctness(mxnet_op, numpy_op, atol=1e-3):
check_gather()
check_binary_broadcast()
+def test_linalg():
+ def check_potrf():
+ # creating an identity matrix input
+ A = nd.zeros((LARGE_SQ_X, LARGE_SQ_X))
+ for i in range(LARGE_SQ_X):
+ A[i,i] = 1
+
+ out = nd.linalg.potrf(A)
+ # output should be an identity matrix
+ for i in range(LARGE_SQ_X):
Review comment:
I'll refactor this with a follow-up PR that includes backwards tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org