You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/08 07:51:09 UTC
[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #356: interpreters/duktape: Fix build warning for sim on macOS
no1wudi opened a new pull request #356:
URL: https://github.com/apache/incubator-nuttx-apps/pull/356
## Summary
See #355
## Impact
sim:duktape on macOS
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #356: interpreters/duktape: Fix build warning for sim on macOS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #356:
URL: https://github.com/apache/incubator-nuttx-apps/pull/356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #356: interpreters/duktape: Fix build warning for sim on macOS
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #356:
URL: https://github.com/apache/incubator-nuttx-apps/pull/356#discussion_r467456882
##########
File path: interpreters/duktape/duk_cmdline.patch
##########
@@ -21,3 +21,15 @@ diff --color -ur duktape-2.5.0/src-noline/duk_config.h duktape-2.5.0-modifed/src
-#define DUK_USE_DATE_PRS_STRPTIME
+#undef DUK_USE_DATE_PRS_STRPTIME
#define DUK_USE_DATE_FMT_STRFTIME
+
+
+diff --color -ur duktape-2.5.0/src-noline/duk_config.h duktape-2.5.0-modifed/src-noline/duk_config.h
Review comment:
The config header detect the sim platform as Linux or macOS even unix, so we need these changes.
Maybe we can add NuttX platform defination into duktape.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #356: interpreters/duktape: Fix build warning for sim on macOS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #356:
URL: https://github.com/apache/incubator-nuttx-apps/pull/356#discussion_r467452478
##########
File path: interpreters/duktape/duk_cmdline.patch
##########
@@ -21,3 +21,15 @@ diff --color -ur duktape-2.5.0/src-noline/duk_config.h duktape-2.5.0-modifed/src
-#define DUK_USE_DATE_PRS_STRPTIME
+#undef DUK_USE_DATE_PRS_STRPTIME
#define DUK_USE_DATE_FMT_STRFTIME
+
+
+diff --color -ur duktape-2.5.0/src-noline/duk_config.h duktape-2.5.0-modifed/src-noline/duk_config.h
Review comment:
can we merge the change into one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org