You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ZENOTME (via GitHub)" <gi...@apache.org> on 2025/01/07 14:28:36 UTC
[PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
ZENOTME opened a new pull request, #882:
URL: https://github.com/apache/iceberg-rust/pull/882
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1923063609
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -226,8 +228,10 @@ pub enum PrimitiveType {
/// Timestamp in microsecond precision, with timezone
Timestamptz,
/// Timestamp in nanosecond precision, without timezone
+ #[serde(rename = "timestamp_ns")]
Review Comment:
Thanks! @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "sdd (via GitHub)" <gi...@apache.org>.
sdd commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1908312861
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -45,6 +45,11 @@ use crate::{Error, ErrorKind};
/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
pub(crate) const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+/// UTC time zone for Arrow timestamp type.
+pub const UTC_TIME_ZONE: &str = "+00:00";
+/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
+pub const MAP_KEY_VALUE_FIELD_NAME: &str = "key_value";
Review Comment:
how does this differ from DEFAULT_MAP_FIELD_NAME above? The descriptions in their comments are the same.
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -45,6 +45,11 @@ use crate::{Error, ErrorKind};
/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
pub(crate) const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+/// UTC time zone for Arrow timestamp type.
+pub const UTC_TIME_ZONE: &str = "+00:00";
+/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
+pub const MAP_KEY_VALUE_FIELD_NAME: &str = "key_value";
Review Comment:
how does this differ from `DEFAULT_MAP_FIELD_NAME` above? The descriptions in their comments are the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1922964129
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -226,8 +228,10 @@ pub enum PrimitiveType {
/// Timestamp in microsecond precision, with timezone
Timestamptz,
/// Timestamp in nanosecond precision, without timezone
+ #[serde(rename = "timestamp_ns")]
Review Comment:
I would suggest to do it in another pr with some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "sdd (via GitHub)" <gi...@apache.org>.
sdd commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1912774587
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -351,19 +383,26 @@ impl ArrowReader {
true
});
- if column_map.len() != field_ids.len() {
+ if column_map.len() != leaf_field_ids.len() {
+ let miss_field = leaf_field_ids
Review Comment:
This var should be called `missing_fields` I think, and similarly in the associated `with_context` (I love that these contexts are getting added by the way 😄 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "sdd (via GitHub)" <gi...@apache.org>.
sdd commented on PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#issuecomment-2586413839
This is looking great, especially now that we have this really comprehensive integration test. Just those two small typos to fix and I'll happily approve - thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 merged PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1908428755
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -45,6 +45,11 @@ use crate::{Error, ErrorKind};
/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
pub(crate) const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+/// UTC time zone for Arrow timestamp type.
+pub const UTC_TIME_ZONE: &str = "+00:00";
+/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
+pub const MAP_KEY_VALUE_FIELD_NAME: &str = "key_value";
Review Comment:
Nice catch. Remove duplicate one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "sdd (via GitHub)" <gi...@apache.org>.
sdd commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1912775863
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -36,9 +36,11 @@ use crate::spec::datatypes::_decimal::{MAX_PRECISION, REQUIRED_LENGTH};
use crate::spec::PrimitiveLiteral;
/// Field name for list type.
-pub(crate) const LIST_FILED_NAME: &str = "element";
-pub(crate) const MAP_KEY_FIELD_NAME: &str = "key";
-pub(crate) const MAP_VALUE_FIELD_NAME: &str = "value";
+pub const LIST_FILED_NAME: &str = "element";
Review Comment:
Typo: `FILED` => `FIELD`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1923062532
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -226,8 +228,10 @@ pub enum PrimitiveType {
/// Timestamp in microsecond precision, with timezone
Timestamptz,
/// Timestamp in nanosecond precision, without timezone
+ #[serde(rename = "timestamp_ns")]
Review Comment:
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1923050271
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -226,8 +228,10 @@ pub enum PrimitiveType {
/// Timestamp in microsecond precision, with timezone
Timestamptz,
/// Timestamp in nanosecond precision, without timezone
+ #[serde(rename = "timestamp_ns")]
Review Comment:
I have separate out this to #905. Let's merge this first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1921001935
##########
crates/integration_tests/tests/scan_all_type.rs:
##########
Review Comment:
A good example could be found here: https://github.com/apache/iceberg/blob/1f6ff6c70c8c921f56ee9d538f14a0eca6cfe00c/data/src/test/java/org/apache/iceberg/data/TestReadProjection.java#L39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1922964452
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -43,7 +43,9 @@ use crate::spec::{
use crate::{Error, ErrorKind};
/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
-pub(crate) const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+pub const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+/// UTC time zone for Arrow timestamp type.
+pub const UTC_TIME_ZONE: &str = "+00:00";
Review Comment:
Is this also required to be public?
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -43,7 +43,9 @@ use crate::spec::{
use crate::{Error, ErrorKind};
/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
-pub(crate) const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+pub const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+/// UTC time zone for Arrow timestamp type.
+pub const UTC_TIME_ZONE: &str = "+00:00";
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#issuecomment-2601477027
> I think it's a step moving forward, but I think this pr didn't handle nested struct type well, see https://github.com/apache/iceberg-rust/issues/405
Hi @liurenjie1024, could you elaborate which part this PR miss? This PR is not intent to complete #405. It only support nest type but not the projected nested filed of structs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1921861153
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -43,7 +43,9 @@ use crate::spec::{
use crate::{Error, ErrorKind};
/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
-pub(crate) const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+pub const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
Review Comment:
The reason we need to make them public is to construct the meta of the write record batch like: https://github.com/apache/iceberg-rust/blob/c44311aa88c505ce8ddce22bed7448a77213e563/crates/integration_tests/tests/scan_all_type.rs#L277.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1921861930
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -226,8 +228,10 @@ pub enum PrimitiveType {
/// Timestamp in microsecond precision, with timezone
Timestamptz,
/// Timestamp in nanosecond precision, without timezone
+ #[serde(rename = "timestamp_ns")]
Review Comment:
[scan_all_type.rs](https://github.com/apache/iceberg-rust/pull/882/files/c44311aa88c505ce8ddce22bed7448a77213e563#diff-c15373e1fa9c9e75b55e5e7e6677b5bb2595974062520e1ae3325205c65802ee) find this bug and I fix it here. I can separate it out of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#issuecomment-2575597063
cc @liurenjie1024 @Xuanwo @Fokko @sdd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#issuecomment-2586489936
Thanks @sdd! I have fixed the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1922963798
##########
crates/iceberg/src/scan.rs:
##########
@@ -248,29 +248,6 @@ impl<'a> TableScanBuilder<'a> {
)
})?;
- let field = schema
- .as_struct()
- .field_by_id(field_id)
- .ok_or_else(|| {
- Error::new(
- ErrorKind::FeatureUnsupported,
- format!(
- "Column {} is not a direct child of schema but a nested field, which is not supported now. Schema: {}",
- column_name, schema
- ),
- )
- })?;
Review Comment:
Hi, @ZENOTME If we only want to support nested types without supporting deeply nested types, we can't remove this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1923051061
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -43,7 +43,9 @@ use crate::spec::{
use crate::{Error, ErrorKind};
/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
-pub(crate) const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+pub const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+/// UTC time zone for Arrow timestamp type.
+pub const UTC_TIME_ZONE: &str = "+00:00";
Review Comment:
Yes. When users provide the timestamp data, they should set the time zone consistent with the iceberg. I think we can provide something to help user fill the metadata later.🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1920988957
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -43,7 +43,9 @@ use crate::spec::{
use crate::{Error, ErrorKind};
/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
-pub(crate) const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+pub const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
Review Comment:
Why we need to make them public?
##########
crates/integration_tests/tests/scan_all_type.rs:
##########
Review Comment:
Could we add some more test cases? I think we are missing handling the case in https://github.com/apache/iceberg-rust/issues/405
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -226,8 +228,10 @@ pub enum PrimitiveType {
/// Timestamp in microsecond precision, with timezone
Timestamptz,
/// Timestamp in nanosecond precision, without timezone
+ #[serde(rename = "timestamp_ns")]
Review Comment:
This is correct, but why is it related with reading complex type?
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -43,7 +43,9 @@ use crate::spec::{
use crate::{Error, ErrorKind};
/// When iceberg map type convert to Arrow map type, the default map field name is "key_value".
-pub(crate) const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+pub const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+/// UTC time zone for Arrow timestamp type.
+pub const UTC_TIME_ZONE: &str = "+00:00";
Review Comment:
Ditto.
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -36,9 +36,11 @@ use crate::spec::datatypes::_decimal::{MAX_PRECISION, REQUIRED_LENGTH};
use crate::spec::PrimitiveLiteral;
/// Field name for list type.
-pub(crate) const LIST_FILED_NAME: &str = "element";
-pub(crate) const MAP_KEY_FIELD_NAME: &str = "key";
-pub(crate) const MAP_VALUE_FIELD_NAME: &str = "value";
+pub const LIST_FIELD_NAME: &str = "element";
+/// Field name for map type's key.
+pub const MAP_KEY_FIELD_NAME: &str = "key";
+/// Field name for map type's value.
+pub const MAP_VALUE_FIELD_NAME: &str = "value";
Review Comment:
Same question why we need to make them public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org