You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/12/08 11:33:35 UTC
Review Request 64446: Log Search UI: improve histogram display
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64446/
-----------------------------------------------------------
Review request for Ambari and Oleg Nechiporenko.
Bugs: AMBARI-22615
https://issues.apache.org/jira/browse/AMBARI-22615
Repository: ambari
Description
-------
1. Add tooltip over columns
2. Add legend
3. Add display of selected time interval length
4. Reduce the height of the histogram
5. When narrowing in on time in the histogram we need to make the bars wider to fill more of the gap
6. Also when zooming in we should have text to tell you the gap
7. The amount of space between the y axis and the bars needs to be increased
Diffs
-----
ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts dee5d98
ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less a6e5616
ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.html 299e46e
ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.less e8d3240
ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.spec.ts 9e056be
ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.ts e255166
ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts e754aa4
ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 6c916aa
Diff: https://reviews.apache.org/r/64446/diff/1/
Testing
-------
Executed 221 of 221 SUCCESS (5.452 secs / 5.358 secs)
Thanks,
Andrii Babiichuk
Re: Review Request 64446: Log Search UI: improve histogram display
Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64446/#review193241
-----------------------------------------------------------
Ship it!
Ship It!
- Oleg Nechiporenko
On Dec. 8, 2017, 11:33 a.m., Andrii Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64446/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 11:33 a.m.)
>
>
> Review request for Ambari and Oleg Nechiporenko.
>
>
> Bugs: AMBARI-22615
> https://issues.apache.org/jira/browse/AMBARI-22615
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Add tooltip over columns
> 2. Add legend
> 3. Add display of selected time interval length
> 4. Reduce the height of the histogram
> 5. When narrowing in on time in the histogram we need to make the bars wider to fill more of the gap
> 6. Also when zooming in we should have text to tell you the gap
> 7. The amount of space between the y axis and the bars needs to be increased
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts dee5d98
> ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less a6e5616
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.html 299e46e
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.less e8d3240
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.spec.ts 9e056be
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.ts e255166
> ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts e754aa4
> ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 6c916aa
>
>
> Diff: https://reviews.apache.org/r/64446/diff/1/
>
>
> Testing
> -------
>
> Executed 221 of 221 SUCCESS (5.452 secs / 5.358 secs)
>
>
> Thanks,
>
> Andrii Babiichuk
>
>