You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/06/29 09:52:48 UTC
[GitHub] [sling-org-apache-sling-repoinit-parser] henrykuijpers opened a new pull request #13: SLING-10136 Add operation for deleting a path
henrykuijpers opened a new pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on pull request #13: SLING-10136 Add operation for deleting a path
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/13#issuecomment-894225566
Sorry that I took so long to take a look at this.
The code looks good to me.
In SLING-10136, Konrad expresses concerns about implementing this operation, I think those should be addressed before merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] henrykuijpers commented on pull request #13: SLING-10136 Add operation for deleting a path
Posted by GitBox <gi...@apache.org>.
henrykuijpers commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/13#issuecomment-882354799
@bdelacretaz Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on pull request #13: SLING-10136 Add operation for deleting a path
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/13#issuecomment-894245812
> How can we address this issue though?
I think best is to discuss it in SLING-10136, I added some comments there. I might not be available in the next few days to discuss more, don't wait for me if you reach consensus there!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] henrykuijpers commented on pull request #13: SLING-10136 Add operation for deleting a path
Posted by GitBox <gi...@apache.org>.
henrykuijpers commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/13#issuecomment-894226999
> Sorry that I took so long to take a look at this.
>
> The code looks good to me.
>
> In SLING-10136, Konrad expresses concerns about implementing this operation, I think those should be addressed before merging this.
I agree! How can we address this issue though? I'm fine with any concensus we can reach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] henrykuijpers commented on pull request #13: SLING-10136 Add operation for deleting a path
Posted by GitBox <gi...@apache.org>.
henrykuijpers commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/13#issuecomment-882354799
@bdelacretaz Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org