[GitHub] [superset] eschutho commented on pull request #22325: feat(RLS): RESTful apis and react view for RLS

[GitBox <gi...@apache.org>]

eschutho commented on PR #22325:
URL: https://github.com/apache/superset/pull/22325#issuecomment-1396170826

   > Heads up that changing `RLS_FORM_QUERY_REL_FIELDS` to `RLS_FILTER_RELATED_FIELDS` may affect deployments that customize this value in various ways - are we OK with this change or would this constitute a breaking change (even if it's easy to correct)? CC @eschutho @john-bodley @dpgaspar
   
   yeah, I would consider this a breaking change, because it changes the name of a config. I noticed the comment in "Breaking changes" in UPDATING.MD as well. I think we're going to run into issues in the 2.1.0 release for our users. Can we try adding a new config, and reading either flag for now in order to make this backward compatible, and then remove the old config in 3.0?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org