You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by cw...@apache.org on 2018/10/04 22:33:01 UTC

svn commit: r1842854 - /uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/protocol/builtin/DefaultServiceProtocolHandler.java

Author: cwiklik
Date: Thu Oct  4 22:33:01 2018
New Revision: 1842854

URL: http://svn.apache.org/viewvc?rev=1842854&view=rev
Log:
UIMA-5877 fail fast on init errors. If a single thread fails during init, remaining threads should not attempt initialization

Modified:
    uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/protocol/builtin/DefaultServiceProtocolHandler.java

Modified: uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/protocol/builtin/DefaultServiceProtocolHandler.java
URL: http://svn.apache.org/viewvc/uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/protocol/builtin/DefaultServiceProtocolHandler.java?rev=1842854&r1=1842853&r2=1842854&view=diff
==============================================================================
--- uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/protocol/builtin/DefaultServiceProtocolHandler.java (original)
+++ uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/protocol/builtin/DefaultServiceProtocolHandler.java Thu Oct  4 22:33:01 2018
@@ -26,8 +26,6 @@ import java.util.concurrent.CountDownLat
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.locks.ReentrantLock;
 
-import org.apache.http.HttpResponse;
-import org.apache.http.client.methods.HttpPost;
 import org.apache.uima.UIMAFramework;
 import org.apache.uima.ducc.ps.net.iface.IMetaTask;
 import org.apache.uima.ducc.ps.net.iface.IMetaTaskTransaction;
@@ -98,15 +96,15 @@ public class DefaultServiceProtocolHandl
 
 	private void initialize() throws ServiceInitializationException {
 
-		if (initError) {
-			return;
-		}
 		// this latch blocks all process threads after initialization
 		// until application calls start()
 		startLatch = new CountDownLatch(1);
 		try {
 			// use a lock to serialize initialization one thread at a time
 			initLock.lock();
+			if (initError) {
+				return;
+			}
 			processor.initialize();
 		} catch (Throwable e) {
 			initError = true;
@@ -453,4 +451,10 @@ public class DefaultServiceProtocolHandl
 	            return new DefaultServiceProtocolHandler(this);
 	        }
 	 }
+
+
+	@Override
+	public boolean initialized() {
+		return ( initError==false );
+	}
 }