You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@commons.apache.org by bo...@apache.org on 2013/12/07 16:27:21 UTC

svn commit: r1548929 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/snappy/SnappyCompressorInputStream.java

Author: bodewig
Date: Sat Dec  7 15:27:21 2013
New Revision: 1548929

URL: http://svn.apache.org/r1548929
Log:
COMPRESS-147 yet another theoretical int overflow

Modified:
    commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/snappy/SnappyCompressorInputStream.java

Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/snappy/SnappyCompressorInputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/snappy/SnappyCompressorInputStream.java?rev=1548929&r1=1548928&r2=1548929&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/snappy/SnappyCompressorInputStream.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/snappy/SnappyCompressorInputStream.java Sat Dec  7 15:27:21 2013
@@ -231,7 +231,7 @@ public class SnappyCompressorInputStream
                 offset = readOneByte();
                 offset |= readOneByte() << 8;
                 offset |= readOneByte() << 16;
-                offset |= readOneByte() << 24;
+                offset |= ((long) readOneByte()) << 24;
 
                 if (expandCopy(offset, length)) {
                     return;