You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2015/09/29 20:10:53 UTC

[1/3] cordova-plugin-contacts git commit: Do not return absolute path for contact images.

Repository: cordova-plugin-contacts
Updated Branches:
  refs/heads/master 0bbc2303b -> 3588895e9


Do not return absolute path for contact images.

Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/16942ffd
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/16942ffd
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/16942ffd

Branch: refs/heads/master
Commit: 16942ffdcd725be763acb76d40dce91b518de7df
Parents: 5c3c71c
Author: Abhishek Hingnikar <ab...@hingnikar.com>
Authored: Sat Jun 27 05:59:41 2015 +0530
Committer: Abhishek Hingnikar <ab...@hingnikar.com>
Committed: Sat Jun 27 05:59:41 2015 +0530

----------------------------------------------------------------------
 src/windows/ContactProxy.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/16942ffd/src/windows/ContactProxy.js
----------------------------------------------------------------------
diff --git a/src/windows/ContactProxy.js b/src/windows/ContactProxy.js
index 04b6e55..60e7166 100644
--- a/src/windows/ContactProxy.js
+++ b/src/windows/ContactProxy.js
@@ -106,10 +106,10 @@ function convertToContact(windowsContact) {
         contact.note = contactNotes;
     }
 
-    // thumbnail field available on Windows 8.1/WP8.1 only
+    // returned is a file, a blob url can be made 
     var contactPhoto = windowsContact.thumbnail;
     if (contactPhoto && contactPhoto.path) {
-        contact.photos = [new ContactField(null, contactPhoto.path , false)];
+        contact.photos = [new ContactField(null, URL.createObjectURL(contactPhoto) , false)];
     }
 
     return contact;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[2/3] cordova-plugin-contacts git commit: Update ContactProxy.js

Posted by pu...@apache.org.
Update ContactProxy.js

Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/dc5537e0
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/dc5537e0
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/dc5537e0

Branch: refs/heads/master
Commit: dc5537e0d6099015ac61f3bd2c6a34442fbc20aa
Parents: 16942ff
Author: Abhishek Hingnikar <ab...@hingnikar.com>
Authored: Sat Jun 27 06:04:29 2015 +0530
Committer: Abhishek Hingnikar <ab...@hingnikar.com>
Committed: Sat Jun 27 06:04:29 2015 +0530

----------------------------------------------------------------------
 src/windows/ContactProxy.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/dc5537e0/src/windows/ContactProxy.js
----------------------------------------------------------------------
diff --git a/src/windows/ContactProxy.js b/src/windows/ContactProxy.js
index 60e7166..bc410a5 100644
--- a/src/windows/ContactProxy.js
+++ b/src/windows/ContactProxy.js
@@ -109,7 +109,7 @@ function convertToContact(windowsContact) {
     // returned is a file, a blob url can be made 
     var contactPhoto = windowsContact.thumbnail;
     if (contactPhoto && contactPhoto.path) {
-        contact.photos = [new ContactField(null, URL.createObjectURL(contactPhoto) , false)];
+        contact.photos = [new ContactField('url', URL.createObjectURL(contactPhoto) , false)];
     }
 
     return contact;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[3/3] cordova-plugin-contacts git commit: Merge branch 'patch-1' of https://github.com/darkyen/cordova-plugin-contacts

Posted by pu...@apache.org.
Merge branch 'patch-1' of https://github.com/darkyen/cordova-plugin-contacts


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/3588895e
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/3588895e
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/3588895e

Branch: refs/heads/master
Commit: 3588895e9a675a165f4b843c4e1d1a4ee7dbaa55
Parents: 0bbc230 dc5537e
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Tue Sep 29 11:10:37 2015 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Tue Sep 29 11:10:37 2015 -0700

----------------------------------------------------------------------
 src/windows/ContactProxy.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org