You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "William Bardwell (JIRA)" <ji...@apache.org> on 2012/05/08 22:07:48 UTC

[jira] [Commented] (TS-1181) TSHttpTxnConfigInt* don't look right with MgmtByte fields in OverridableHttpConfigParams

    [ https://issues.apache.org/jira/browse/TS-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270783#comment-13270783 ] 

William Bardwell commented on TS-1181:
--------------------------------------

Those changes look good to me.
                
> TSHttpTxnConfigInt* don't look right with MgmtByte fields in OverridableHttpConfigParams
> ----------------------------------------------------------------------------------------
>
>                 Key: TS-1181
>                 URL: https://issues.apache.org/jira/browse/TS-1181
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>    Affects Versions: 3.0.4
>            Reporter: William Bardwell
>            Assignee: Leif Hedstrom
>            Priority: Minor
>             Fix For: 3.1.4
>
>
> TSHttpTxnConfigIntSet and Get use _conf_to_memberp to get a pointer to various fields, and then access it as a 32bit int.  But many of the fields are now bytes.  A fix would be to make _conf_to_memberp return the type properly, and make TSHttpTxnConfigInt* access the field as the proper size.
> I saw valgrind complaining about uninitialized data from the code (which is probably because of padding in the structure, since it is cleared a field at a time), but there are probably much worse effects around reading and writing unrelated fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira