[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1447: [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId

["zhongqiangczq (via GitHub)" <gi...@apache.org>]

zhongqiangczq commented on code in PR #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447#discussion_r1173674937


##########
common/src/main/java/org/apache/celeborn/common/protocol/PartitionLocation.java:
##########
@@ -286,13 +285,9 @@ public String toString() {
       peerAddr = peer.hostAndPorts();
     }
     return "PartitionLocation["
-        + "\n  id(rawId-attemptId)-epoch:"
+        + "\n  id-epoch:"

Review Comment:
   if we want to look at shufflewring filename of one map task, it's not directly to build the relation between filename (  id + "-" + epoch + "-" + mode.mode) and the mapid 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org