You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/13 16:33:24 UTC
[GitHub] [beam] davidyan74 commented on a change in pull request #13088: [BEAM-11056] Fix warning message and rename old APIs (#13080)
davidyan74 commented on a change in pull request #13088:
URL: https://github.com/apache/beam/pull/13088#discussion_r504095151
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -52,98 +53,117 @@
class Options(interactive_options.InteractiveOptions):
"""Options that guide how Interactive Beam works."""
@property
- def enable_capture_replay(self):
- """Whether replayable source data capture should be replayed for multiple
- PCollection evaluations and pipeline runs as long as the data captured is
+ def enable_recording_replay(self):
+ """Whether replayable source data recorded should be replayed for multiple
+ PCollection evaluations and pipeline runs as long as the data recorded is
still valid."""
return self.capture_control._enable_capture_replay
- @enable_capture_replay.setter
- def enable_capture_replay(self, value):
- """Sets whether source data capture should be replayed. True - Enables
- capture of replayable source data so that following PCollection evaluations
- and pipeline runs always use the same data captured; False - Disables
- capture of replayable source data so that following PCollection evaluation
- and pipeline runs always use new data from sources."""
+ @enable_recording_replay.setter
+ def enable_recording_replay(self, value):
+ """Sets whether source data recorded should be replayed. True - Enables
+ recording of replayable source data so that following PCollection
+ evaluations and pipeline runs always use the same data recorded;
+ False - Disables recording of replayable source data so that following
+ PCollection evaluation and pipeline runs always use new data from sources.
+ """
# This makes sure the log handler is configured correctly in case the
# options are configured in an early stage.
_ = ie.current_env()
if value:
_LOGGER.info(
- 'Capture replay is enabled. When a PCollection is evaluated or the '
- 'pipeline is executed, existing data captured from previous '
+ 'Record replay is enabled. When a PCollection is evaluated or the '
Review comment:
Recording?
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -52,98 +53,117 @@
class Options(interactive_options.InteractiveOptions):
"""Options that guide how Interactive Beam works."""
@property
- def enable_capture_replay(self):
- """Whether replayable source data capture should be replayed for multiple
- PCollection evaluations and pipeline runs as long as the data captured is
+ def enable_recording_replay(self):
+ """Whether replayable source data recorded should be replayed for multiple
+ PCollection evaluations and pipeline runs as long as the data recorded is
still valid."""
return self.capture_control._enable_capture_replay
- @enable_capture_replay.setter
- def enable_capture_replay(self, value):
- """Sets whether source data capture should be replayed. True - Enables
- capture of replayable source data so that following PCollection evaluations
- and pipeline runs always use the same data captured; False - Disables
- capture of replayable source data so that following PCollection evaluation
- and pipeline runs always use new data from sources."""
+ @enable_recording_replay.setter
+ def enable_recording_replay(self, value):
+ """Sets whether source data recorded should be replayed. True - Enables
+ recording of replayable source data so that following PCollection
+ evaluations and pipeline runs always use the same data recorded;
+ False - Disables recording of replayable source data so that following
+ PCollection evaluation and pipeline runs always use new data from sources.
+ """
# This makes sure the log handler is configured correctly in case the
# options are configured in an early stage.
_ = ie.current_env()
if value:
_LOGGER.info(
- 'Capture replay is enabled. When a PCollection is evaluated or the '
- 'pipeline is executed, existing data captured from previous '
+ 'Record replay is enabled. When a PCollection is evaluated or the '
Review comment:
I'd say this can be done after 2.25, so don't let this be a blocker.
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -52,98 +53,117 @@
class Options(interactive_options.InteractiveOptions):
"""Options that guide how Interactive Beam works."""
@property
- def enable_capture_replay(self):
- """Whether replayable source data capture should be replayed for multiple
- PCollection evaluations and pipeline runs as long as the data captured is
+ def enable_recording_replay(self):
+ """Whether replayable source data recorded should be replayed for multiple
+ PCollection evaluations and pipeline runs as long as the data recorded is
still valid."""
return self.capture_control._enable_capture_replay
- @enable_capture_replay.setter
- def enable_capture_replay(self, value):
- """Sets whether source data capture should be replayed. True - Enables
- capture of replayable source data so that following PCollection evaluations
- and pipeline runs always use the same data captured; False - Disables
- capture of replayable source data so that following PCollection evaluation
- and pipeline runs always use new data from sources."""
+ @enable_recording_replay.setter
+ def enable_recording_replay(self, value):
+ """Sets whether source data recorded should be replayed. True - Enables
+ recording of replayable source data so that following PCollection
+ evaluations and pipeline runs always use the same data recorded;
+ False - Disables recording of replayable source data so that following
+ PCollection evaluation and pipeline runs always use new data from sources.
+ """
# This makes sure the log handler is configured correctly in case the
# options are configured in an early stage.
_ = ie.current_env()
if value:
_LOGGER.info(
- 'Capture replay is enabled. When a PCollection is evaluated or the '
- 'pipeline is executed, existing data captured from previous '
+ 'Record replay is enabled. When a PCollection is evaluated or the '
+ 'pipeline is executed, existing data recorded from previous '
'computations will be replayed for consistent results. If no '
- 'captured data is available, new data from capturable sources will '
- 'be captured.')
+ 'recorded data is available, new data from recordable sources will '
+ 'be recorded.')
else:
_LOGGER.info(
- 'Capture replay is disabled. The next time a PCollection is '
+ 'Record replay is disabled. The next time a PCollection is '
Review comment:
Ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org