You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/01 10:46:31 UTC

[GitHub] [pulsar] WJL3333 commented on a diff in pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats

WJL3333 commented on code in PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#discussion_r1010303185


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1435,14 +1437,15 @@ protected void internalGetPartitionedStats(AsyncResponse asyncResponse, boolean
                         .thenCompose(owned -> {
                             if (owned) {
                                 return getTopicReferenceAsync(partition)
-                                    .thenApply(ref ->
-                                        ref.getStats(getPreciseBacklog, subscriptionBacklogSize,
-                                            getEarliestTimeInBacklog));
+                                        .thenApply(ref ->
+                                                ref.getStats(getPreciseBacklog, subscriptionBacklogSize,

Review Comment:
   i think we can add some class `XXXXOption` to encapsulate these boolean config.
   if we add more boolean config it will be easy to just change `XXXXOption` without too much change the related code.  And it improves the code quality to make method signature with less parameter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org