You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Matt Foley (JIRA)" <ji...@apache.org> on 2011/07/07 00:33:16 UTC
[jira] [Created] (HADOOP-7448) merge from yahoo-merge: HttpServer
/stacks servlet should use plain text content type
merge from yahoo-merge: HttpServer /stacks servlet should use plain text content type
-------------------------------------------------------------------------------------
Key: HADOOP-7448
URL: https://issues.apache.org/jira/browse/HADOOP-7448
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.23.0
Reporter: Matt Foley
Assignee: Matt Foley
Fix For: 0.23.0
Fix incomplete merge from yahoo-merge branch:
-r 1079157: Fix content type for /stacks servlet (Luke Lu)
-r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7448) merge for MR-279: HttpServer /stacks
servlet should use plain text content type
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HADOOP-7448:
-------------------------------
Description:
Fix incomplete merge from yahoo-merge branch to trunk:
-r 1079157: Fix content type for /stacks servlet (Luke Lu)
-r 1079164: No need to escape plain text (Luke Lu)
was:
Fix incomplete merge from yahoo-merge branch to MR-279 branch:
-r 1079157: Fix content type for /stacks servlet (Luke Lu)
-r 1079164: No need to escape plain text (Luke Lu)
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: HttpServlet_stacks_v1.patch
>
>
> Fix incomplete merge from yahoo-merge branch to trunk:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7448) merge for MR-279: HttpServer /stacks
servlet should use plain text content type
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HADOOP-7448:
-------------------------------
Status: Patch Available (was: Open)
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: HttpServlet_stacks_v1.patch
>
>
> Fix incomplete merge from yahoo-merge branch to MR-279 branch:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7448) merge for MR-279: HttpServer
/stacks servlet should use plain text content type
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060961#comment-13060961 ]
Hudson commented on HADOOP-7448:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #678 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/678/])
HADOOP-7448. Merge from yahoo-merge branch -r 1079157 and -r 1079164: HttpServer /stacks servlet should use plain text content type, without escaping. Contributed by Luke Lu.
mattf : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1143613
Files :
* /hadoop/common/trunk/common/src/java/org/apache/hadoop/http/HttpServer.java
* /hadoop/common/trunk/common/CHANGES.txt
* /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/http/TestHttpServer.java
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: HttpServlet_stacks_v1.patch
>
>
> Fix incomplete merge from yahoo-merge branch to trunk:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7448) merge for MR-279: HttpServer
/stacks servlet should use plain text content type
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060948#comment-13060948 ]
Matt Foley commented on HADOOP-7448:
------------------------------------
Hudson came back! The four release audit warnings are not related to this merge. Passed everything else.
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: HttpServlet_stacks_v1.patch
>
>
> Fix incomplete merge from yahoo-merge branch to trunk:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7448) merge for MR-279: HttpServer /stacks
servlet should use plain text content type
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HADOOP-7448:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Hudson is not responding, so ran tests locally, and passed.
The merge required a conflict resolution, so I posted the resulting patch here. But committing as a merge so full history is available in the svn record.
Committed to trunk.
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: HttpServlet_stacks_v1.patch
>
>
> Fix incomplete merge from yahoo-merge branch to trunk:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7448) merge for MR-279: HttpServer /stacks
servlet should use plain text content type
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HADOOP-7448:
-------------------------------
Description:
Fix incomplete merge from yahoo-merge branch to MR-279 branch:
-r 1079157: Fix content type for /stacks servlet (Luke Lu)
-r 1079164: No need to escape plain text (Luke Lu)
was:
Fix incomplete merge from yahoo-merge branch:
-r 1079157: Fix content type for /stacks servlet (Luke Lu)
-r 1079164: No need to escape plain text (Luke Lu)
Summary: merge for MR-279: HttpServer /stacks servlet should use plain text content type (was: merge from yahoo-merge: HttpServer /stacks servlet should use plain text content type)
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
>
> Fix incomplete merge from yahoo-merge branch to MR-279 branch:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7448) merge for MR-279: HttpServer
/stacks servlet should use plain text content type
Posted by "Luke Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060901#comment-13060901 ]
Luke Lu commented on HADOOP-7448:
---------------------------------
+1 for trunk.
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: HttpServlet_stacks_v1.patch
>
>
> Fix incomplete merge from yahoo-merge branch to MR-279 branch:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7448) merge for MR-279: HttpServer
/stacks servlet should use plain text content type
Posted by "Luke Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060906#comment-13060906 ]
Luke Lu commented on HADOOP-7448:
---------------------------------
It'd be less confusing, if you create an umbrella jira for "Merge required common changes to trunk to get ready for MR-279", or something like that.
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: HttpServlet_stacks_v1.patch
>
>
> Fix incomplete merge from yahoo-merge branch to MR-279 branch:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7448) merge for MR-279: HttpServer
/stacks servlet should use plain text content type
Posted by "Luke Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060899#comment-13060899 ]
Luke Lu commented on HADOOP-7448:
---------------------------------
It seems to me that MR-279 already have the necessary changes.
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: HttpServlet_stacks_v1.patch
>
>
> Fix incomplete merge from yahoo-merge branch to MR-279 branch:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7448) merge for MR-279: HttpServer /stacks
servlet should use plain text content type
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HADOOP-7448:
-------------------------------
Attachment: HttpServlet_stacks_v1.patch
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: HttpServlet_stacks_v1.patch
>
>
> Fix incomplete merge from yahoo-merge branch to MR-279 branch:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7448) merge for MR-279: HttpServer
/stacks servlet should use plain text content type
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060944#comment-13060944 ]
Hadoop QA commented on HADOOP-7448:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12485500/HttpServlet_stacks_v1.patch
against trunk revision 1143606.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 4 release audit warnings (more than the trunk's current 1 warnings).
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/705//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/705//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/705//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/705//console
This message is automatically generated.
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: HttpServlet_stacks_v1.patch
>
>
> Fix incomplete merge from yahoo-merge branch to trunk:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7448) merge for MR-279: HttpServer
/stacks servlet should use plain text content type
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061204#comment-13061204 ]
Hudson commented on HADOOP-7448:
--------------------------------
Integrated in Hadoop-Common-trunk #740 (See [https://builds.apache.org/job/Hadoop-Common-trunk/740/])
HADOOP-7448. Merge from yahoo-merge branch -r 1079157 and -r 1079164: HttpServer /stacks servlet should use plain text content type, without escaping. Contributed by Luke Lu.
mattf : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1143613
Files :
* /hadoop/common/trunk/common/src/java/org/apache/hadoop/http/HttpServer.java
* /hadoop/common/trunk/common/CHANGES.txt
* /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/http/TestHttpServer.java
> merge for MR-279: HttpServer /stacks servlet should use plain text content type
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7448
> URL: https://issues.apache.org/jira/browse/HADOOP-7448
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: HttpServlet_stacks_v1.patch
>
>
> Fix incomplete merge from yahoo-merge branch to trunk:
> -r 1079157: Fix content type for /stacks servlet (Luke Lu)
> -r 1079164: No need to escape plain text (Luke Lu)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira