You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "aiven-anton (via GitHub)" <gi...@apache.org> on 2023/04/15 22:00:25 UTC
[GitHub] [kafka] aiven-anton opened a new pull request, #13583: docs: Correct type of record batch CRC field
aiven-anton opened a new pull request, #13583:
URL: https://github.com/apache/kafka/pull/13583
The CRC field of Record Batch was incorrectly documented as int32 while in reality it's an [unsigned uint32 field](https://github.com/apache/kafka/blob/9c12e462106343fbc6af5873074d48f98687af39/clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java#L52).
<!--
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
-->
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [x] Verify test coverage and CI build status
- [x] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon merged pull request #13583: MINOR: Correct type of record batch CRC field
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon merged PR #13583:
URL: https://github.com/apache/kafka/pull/13583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org