You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2017/11/29 19:15:00 UTC

[GitHub] surajpindoria commented on issue #247: CB-13498 added closebutton option for ios

surajpindoria commented on issue #247: CB-13498 added closebutton option for ios
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247#issuecomment-347965530
 
 
   The code for this looks fine and it works as described. But I am struggling to really find a reason for adding this feature.
   
   - Why would a developer want to have an inappbrowser window with no close button?
   - As a user of the app, how would you close the inappbrowser?
   - Why would this be an iOS specific feature only?
   
   To me this seems like a very specific use case that doesn't warrant adding it back to the main plugin repo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org