You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:48:25 UTC

[GitHub] [thrift] janosvitok commented on pull request #2051: THRIFT-5135: Compiler: Enable C++11 on OSX

janosvitok commented on pull request #2051:
URL: https://github.com/apache/thrift/pull/2051#issuecomment-664873546


   I've checked this. The problem is that when running cmake on the whole tree, DefineCMakeDefaults.cmake is pulled in.
   On the other hand, when running cmake just on compiler/cpp subtree, the relevant macro is not set.
   
   See https://github.com/apache/thrift/blob/master/compiler/cpp/README.md#build-using-cmake that explicitly mentions running cmake from compiler/cpp
   
   Summary: the issue here is lack of cmake documentation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org