[GitHub] [kafka] dengziming commented on a diff in pull request #12729: KAFKA-14285: Delete quota node in zookeeper when configs are empty

[GitBox <gi...@apache.org>]

dengziming commented on code in PR #12729:
URL: https://github.com/apache/kafka/pull/12729#discussion_r1032088188


##########
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##########
@@ -133,8 +133,12 @@ object ConfigCommand extends Logging {
     val entityType = entity.root.entityType
     val entityName = entity.fullSanitizedName
     val errorMessage = s"--bootstrap-server option must be specified to update $entityType configs: {add: $configsToBeAdded, delete: $configsToBeDeleted}"
+    var isUserClientId = false
 
     if (entityType == ConfigType.User) {
+      if (entity.child.exists(e => ConfigType.Client.equals(e.entityType))) {

Review Comment:
   I think we can use `isUserClientId = entity.child.exists(e => ConfigType.Client.equals(e.entityType))` directly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org