You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/17 10:32:19 UTC

[GitHub] [maven-integration-testing] gnodet commented on a change in pull request #134: [MNG-7349] Limit relocation warning message to direct dependencies only

gnodet commented on a change in pull request #134:
URL: https://github.com/apache/maven-integration-testing/pull/134#discussion_r785830649



##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7349RelocationReasonTest.java
##########
@@ -57,6 +58,18 @@ public void testit()
         verifier.executeGoal( "verify" );
         verifier.resetStreams();
         verifier.verifyErrorFreeLog();
-        verifier.verifyTextInLog( "Test relocation reason" );
+        try {
+            verifier.verifyTextInLog("Test relocation reason");
+        } catch (VerificationException e) {

Review comment:
       > Does duplicating the output make sense? The system will print a lot already and the log file can always be inspected by a dev.
   
   Well, that's exactly because I did not find how to do it that I added the output.  The plan is to remove it when the test is fixed, but it's working locally and I currently have no idea why it fails.  The relocation warning is not displayed at all for an unknown reason.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org