You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kenneth Knowles (Jira)" <ji...@apache.org> on 2021/08/17 15:50:00 UTC

[jira] [Updated] (BEAM-12768) test_df_agg_method_invalid_kwarg_raises test too strict on error/string matching

     [ https://issues.apache.org/jira/browse/BEAM-12768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kenneth Knowles updated BEAM-12768:
-----------------------------------
    Status: Open  (was: Triage Needed)

> test_df_agg_method_invalid_kwarg_raises test too strict on error/string matching
> --------------------------------------------------------------------------------
>
>                 Key: BEAM-12768
>                 URL: https://issues.apache.org/jira/browse/BEAM-12768
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core, test-failures
>    Affects Versions: 2.33.0
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: P0
>
> It looks like possibly the restricted pandas version to 1.3.0 made the type error message contents change slightly. Looks like we should relax https://github.com/apache/beam/blame/faac725e98f8422b172a77e8c898af03c15b74c6/sdks/python/apache_beam/dataframe/frames_test.py#L98 to possibly be a substring test
> Example failure:
> https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/4563/testReport/junit/apache_beam.dataframe.frames_test/AggregationTest/test_df_agg_method_invalid_kwarg_raises/
> {noformat}
> AssertionError: Expected TypeError("mean() got an unexpected keyword argument 'bool_only'") to be raised, but got TypeError("DataFrame constructor called with incompatible data and dtype: mean() got an unexpected keyword argument 'bool_only'")
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)