[GitHub] [accumulo] milleruntime commented on issue #1084: Tests failing running against standalone instance

[GitBox <gi...@apache.org>]

milleruntime commented on issue #1084: Tests failing running against standalone instance
URL: https://github.com/apache/accumulo/issues/1084#issuecomment-490175221
 
 
   > ReadWriteIT ... I do not think the code here is really even necessary and doesn't really test anything. When removed the test runs with no issue.
   > 
   > ```
   > if (getCluster() instanceof StandaloneAccumuloCluster) {
   >         StandaloneAccumuloCluster standaloneCluster = (StandaloneAccumuloCluster) getCluster();
   >         File accumuloProps =
   >             new File(standaloneCluster.getServerAccumuloConfDir(), "accumulo.properties");
   >         if (accumuloProps.isFile()) {
   >           Configuration conf = new Configuration(false);
   >           conf.addResource(new Path(accumuloProps.toURI()));
   >           String monitorSslKeystore = conf.get(Property.MONITOR_SSL_KEYSTORE.getKey());
   >           if (monitorSslKeystore != null) {
   >             log.info("Using HTTPS since monitor ssl keystore configuration was observed in {}",
   >                 accumuloProps);
   >             scheme = "https://";
   >             SSLContext ctx = SSLContext.getInstance("TLSv1.2");
   >             TrustManager[] tm = {new TestTrustManager()};
   >             ctx.init(new KeyManager[0], tm, new SecureRandom());
   >             SSLContext.setDefault(ctx);
   >             HttpsURLConnection.setDefaultSSLSocketFactory(ctx.getSocketFactory());
   >             HttpsURLConnection.setDefaultHostnameVerifier(new TestHostnameVerifier());
   >           }
   >         } else {
   >           log.info("{} is not a normal file, not checking for monitor running with SSL",
   >               accumuloProps);
   >         }
   >       }
   > ```
   
   This part of the code may be broken for 2.0... I am not sure SSL works with the new Monitor.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services