You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by JiaTao Tao <ta...@gmail.com> on 2020/10/23 02:43:09 UTC
Why ProjectJoinTransposeRule not in Calcite default rule set.
This rule is only used in RelOptMaterializations#substitute, is not in
Calcite's main optimizer process(RelOptUtil#registerDefaultRules), wonder
why, seems a common rule.
Regards!
Aron Tao
Re: Why ProjectJoinTransposeRule not in Calcite default rule set.
Posted by JiaTao Tao <ta...@gmail.com>.
This rule is used by Flink for a while(since 2019/3), so we are confident
that we can introduce it into the main optimize process.
Regards!
Aron Tao
JiaTao Tao <ta...@gmail.com> 于2020年10月27日周二 下午4:10写道：
> Hi
> I'll enable this rule and run UTs, Why I noticed this rule is because
> Flink uses it as a default rule.
>
> Regards!
>
> Aron Tao
>
>
> Chunwei Lei <ch...@gmail.com> 于2020年10月27日周二 上午10:32写道：
>
>> Note that RelOptUtil#registerDefaultRules is marked as experimental and it
>> excludes quite a few rules.
>> It might not be as perfect as expected. Feel free to improve it if needed.
>>
>>
>> Best,
>> Chunwei
>>
>>
>> On Tue, Oct 27, 2020 at 2:13 AM Rui Wang <am...@apache.org> wrote:
>>
>> > If you include "ProjectJoinTransposeRule" as a default rule, what impact
>> > will it have? Will some unit tests need to be updated?
>> >
>> >
>> > -Rui
>> >
>> > On Mon, Oct 26, 2020 at 2:14 AM Fan Liya <li...@gmail.com> wrote:
>> >
>> > > I also think the ProjectJoinTransposeRule should be included in the
>> main
>> > > optimizer process.
>> > >
>> > > Best,
>> > > Liya Fan
>> > >
>> > > On Fri, Oct 23, 2020 at 10:43 AM JiaTao Tao <ta...@gmail.com>
>> wrote:
>> > >
>> > > > This rule is only used in RelOptMaterializations#substitute, is not
>> in
>> > > > Calcite's main optimizer process(RelOptUtil#registerDefaultRules),
>> > wonder
>> > > > why, seems a common rule.
>> > > >
>> > > >
>> > > > Regards!
>> > > >
>> > > > Aron Tao
>> > > >
>> > >
>> >
>>
>
Re: Why ProjectJoinTransposeRule not in Calcite default rule set.
Posted by JiaTao Tao <ta...@gmail.com>.
Hi
I'll enable this rule and run UTs, Why I noticed this rule is because Flink
uses it as a default rule.
Regards!
Aron Tao
Chunwei Lei <ch...@gmail.com> 于2020年10月27日周二 上午10:32写道：
> Note that RelOptUtil#registerDefaultRules is marked as experimental and it
> excludes quite a few rules.
> It might not be as perfect as expected. Feel free to improve it if needed.
>
>
> Best,
> Chunwei
>
>
> On Tue, Oct 27, 2020 at 2:13 AM Rui Wang <am...@apache.org> wrote:
>
> > If you include "ProjectJoinTransposeRule" as a default rule, what impact
> > will it have? Will some unit tests need to be updated?
> >
> >
> > -Rui
> >
> > On Mon, Oct 26, 2020 at 2:14 AM Fan Liya <li...@gmail.com> wrote:
> >
> > > I also think the ProjectJoinTransposeRule should be included in the
> main
> > > optimizer process.
> > >
> > > Best,
> > > Liya Fan
> > >
> > > On Fri, Oct 23, 2020 at 10:43 AM JiaTao Tao <ta...@gmail.com>
> wrote:
> > >
> > > > This rule is only used in RelOptMaterializations#substitute, is not
> in
> > > > Calcite's main optimizer process(RelOptUtil#registerDefaultRules),
> > wonder
> > > > why, seems a common rule.
> > > >
> > > >
> > > > Regards!
> > > >
> > > > Aron Tao
> > > >
> > >
> >
>
Re: Why ProjectJoinTransposeRule not in Calcite default rule set.
Posted by Chunwei Lei <ch...@gmail.com>.
Note that RelOptUtil#registerDefaultRules is marked as experimental and it
excludes quite a few rules.
It might not be as perfect as expected. Feel free to improve it if needed.
Best,
Chunwei
On Tue, Oct 27, 2020 at 2:13 AM Rui Wang <am...@apache.org> wrote:
> If you include "ProjectJoinTransposeRule" as a default rule, what impact
> will it have? Will some unit tests need to be updated?
>
>
> -Rui
>
> On Mon, Oct 26, 2020 at 2:14 AM Fan Liya <li...@gmail.com> wrote:
>
> > I also think the ProjectJoinTransposeRule should be included in the main
> > optimizer process.
> >
> > Best,
> > Liya Fan
> >
> > On Fri, Oct 23, 2020 at 10:43 AM JiaTao Tao <ta...@gmail.com> wrote:
> >
> > > This rule is only used in RelOptMaterializations#substitute, is not in
> > > Calcite's main optimizer process(RelOptUtil#registerDefaultRules),
> wonder
> > > why, seems a common rule.
> > >
> > >
> > > Regards!
> > >
> > > Aron Tao
> > >
> >
>
Re: Why ProjectJoinTransposeRule not in Calcite default rule set.
Posted by Rui Wang <am...@apache.org>.
If you include "ProjectJoinTransposeRule" as a default rule, what impact
will it have? Will some unit tests need to be updated?
-Rui
On Mon, Oct 26, 2020 at 2:14 AM Fan Liya <li...@gmail.com> wrote:
> I also think the ProjectJoinTransposeRule should be included in the main
> optimizer process.
>
> Best,
> Liya Fan
>
> On Fri, Oct 23, 2020 at 10:43 AM JiaTao Tao <ta...@gmail.com> wrote:
>
> > This rule is only used in RelOptMaterializations#substitute, is not in
> > Calcite's main optimizer process(RelOptUtil#registerDefaultRules), wonder
> > why, seems a common rule.
> >
> >
> > Regards!
> >
> > Aron Tao
> >
>
Re: Why ProjectJoinTransposeRule not in Calcite default rule set.
Posted by Fan Liya <li...@gmail.com>.
I also think the ProjectJoinTransposeRule should be included in the main
optimizer process.
Best,
Liya Fan
On Fri, Oct 23, 2020 at 10:43 AM JiaTao Tao <ta...@gmail.com> wrote:
> This rule is only used in RelOptMaterializations#substitute, is not in
> Calcite's main optimizer process(RelOptUtil#registerDefaultRules), wonder
> why, seems a common rule.
>
>
> Regards!
>
> Aron Tao
>