You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2013/07/29 11:35:52 UTC
[Apache Bloodhound] #615: Trac favicon showing on product dashboards
#615: Trac favicon showing on product dashboards
-----------------------+--------------------
Reporter: mudri | Owner: nobody
Type: defect | Status: new
Priority: major | Milestone:
Component: dashboard | Version:
Keywords: |
-----------------------+--------------------
I've only found this to happen on /products/%40/dashboard, and it has
stopped now I've added another product (I just had the default product
whilst it was happening). Related to #84.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/615>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #615: Trac favicon showing on product
dashboards
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#615: Trac favicon showing on product dashboards
------------------------+-----------------------
Reporter: mudri | Owner: nobody
Type: defect | Status: new
Priority: major | Milestone: Release 8
Component: dashboard | Version:
Resolution: | Keywords:
------------------------+-----------------------
Changes (by rjollos):
* milestone: => Release 8
Comment:
Which browser? I can't reproduce in Chromium 28 (Ubuntu 13.04), however on
Product Dashboard page, I see inside the `head` element:
{{{#!text/html
<link rel="shortcut icon" href="/sqlite/chrome/theme/img/bh.ico"
type="image/x-icon" />
<link rel="shortcut icon"
href="/sqlite/products/%40/chrome/common/trac.ico" type="image/x-icon" />
<link rel="icon" href="/sqlite/chrome/theme/img/bh.ico"
type="image/x-icon" />
<link rel="icon" href="/sqlite/products/%40/chrome/common/trac.ico"
type="image/x-icon" />
}}}
The relevant code is in bloodhound_theme.bhtheme.theme.py:
{{{#!python
# replace favicon if appropriate
if self.env.project_icon == 'common/trac.ico':
bh_icon = 'theme/img/bh.ico'
new_icon = {'href': req.href.chrome(bh_icon),
'type': get_mimetype(bh_icon)}
if links.get('icon'):
links.get('icon')[0].update(new_icon)
if links.get('shortcut icon'):
links.get('shortcut icon')[0].update(new_icon)
}}}
Care to take a try at fixing it?
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/615#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #615: Trac favicon showing on product dashboards
Posted by James Wood <ja...@wandisco.com>.
On Mon, Jul 29, 2013 at 10:35 AM, Apache Bloodhound <
dev@bloodhound.apache.org> wrote:
> #615: Trac favicon showing on product dashboards
> -----------------------+--------------------
> Reporter: mudri | Owner: nobody
> Type: defect | Status: new
> Priority: major | Milestone:
> Component: dashboard | Version:
> Keywords: |
> -----------------------+--------------------
> I've only found this to happen on /products/%40/dashboard, and it has
> stopped now I've added another product (I just had the default product
> whilst it was happening). Related to #84.
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/615>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound issue tracker
>