You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/12/01 06:19:42 UTC

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #877: Showing networks from selected physical network

davidjumani opened a new pull request #877:
URL: https://github.com/apache/cloudstack-primate/pull/877


   ### Before : Showed all guest networks
   ![Screenshot from 2020-12-01 11-47-39](https://user-images.githubusercontent.com/8244774/100704208-19410000-33cb-11eb-8687-0dcdd8f2861f.png)
   
   ### After : Shows guest networks on the current physical network
   ![Screenshot from 2020-12-01 11-47-06](https://user-images.githubusercontent.com/8244774/100704205-17773c80-33cb-11eb-8e3c-79f24c568216.png)
   
   Also removed the add guest network button since it's redundant and won't necessarily be created in the current physical network


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #877: Showing networks from selected physical network

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #877:
URL: https://github.com/apache/cloudstack-primate/pull/877#issuecomment-736315158


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #877: Showing networks from selected physical network

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #877:
URL: https://github.com/apache/cloudstack-primate/pull/877#issuecomment-736249963


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #877: Showing networks from selected physical network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #877:
URL: https://github.com/apache/cloudstack-primate/pull/877#issuecomment-736315893


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #877: Showing networks from selected physical network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #877:
URL: https://github.com/apache/cloudstack-primate/pull/877#issuecomment-736321243


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/877 (JID-3702)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #877: Showing networks from selected physical network

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #877:
URL: https://github.com/apache/cloudstack-primate/pull/877#discussion_r533151579



##########
File path: src/views/infra/network/IpRangesTabGuest.vue
##########
@@ -17,15 +17,6 @@
 
 <template>
   <a-spin :spinning="componentLoading">
-    <a-button
-      :disabled="!('createNetwork' in this.$store.getters.apis)"

Review comment:
       @davidjumani why are we removing this?

##########
File path: src/views/infra/network/IpRangesTabGuest.vue
##########
@@ -138,6 +115,7 @@ export default {
       this.componentLoading = true
       api('listNetworks', {
         zoneid: this.resource.zoneid,
+        physicalnetworkid: this.resource.id,

Review comment:
       this lgtm




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #877: Showing networks from selected physical network

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #877:
URL: https://github.com/apache/cloudstack-primate/pull/877


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org