[jira] [Commented] (SPARK-25716) Project and Aggregate generate valid constraints with unnecessary operation

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-25716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647355#comment-16647355 ] 

Apache Spark commented on SPARK-25716:
--------------------------------------

User 'SongYadong' has created a pull request for this issue:
https://github.com/apache/spark/pull/22706

> Project and Aggregate generate valid constraints with unnecessary operation
> ---------------------------------------------------------------------------
>
>                 Key: SPARK-25716
>                 URL: https://issues.apache.org/jira/browse/SPARK-25716
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.0.0
>            Reporter: SongYadong
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Project logical operator generates valid constraints using two opposite operations. It substracts child constraints from all constraints, than union child constraints again. I think it may be not necessary.
> Aggregate operator has the same problem with Project.
> for example:
> in LogicalPlan.getAliasedConstraints(), return:
> {code:java}
> allConstraints -- child.constraints{code}
> in Project.validConstraints():
> {code:java}
> child.constraints.union(getAliasedConstraints(projectList)){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org