You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/15 01:47:04 UTC

[GitHub] [beam] prodriguezdefino opened a new pull request, #21879: Adding the BASIC view setting to getTable request

prodriguezdefino opened a new pull request, #21879:
URL: https://github.com/apache/beam/pull/21879

   This setting should help to avoid storage related calculations on the BQ table backend (caused by the default option). 
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ayberk commented on a diff in pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
ayberk commented on code in PR #21879:
URL: https://github.com/apache/beam/pull/21879#discussion_r898438085


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServices.java:
##########
@@ -111,6 +111,9 @@ JobStatistics dryRunQuery(
 
   /** An interface to get, create and delete Cloud BigQuery datasets and tables. */
   public interface DatasetService extends AutoCloseable {
+
+    static String TABLE_METADATA_BASIC_VIEW = "BASIC";

Review Comment:
   I'd create an enum to represent this and include all options. Then we can pass the current default (STATS) explicitly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1159205614

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1155884123

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] prodriguezdefino commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
prodriguezdefino commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1156960279

   > 
   
   I think those clients that are using previously existing signatures of the getTable method should not see a different behavior, then change adds a new signature that gets used in those PTransform that would take advantage of the latencies reduction. The previously existing signatures of the method are still delivering the FULL view (which includes the storage stats for the table). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1155884120

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1158323873

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1158323982

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] prodriguezdefino commented on a diff in pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
prodriguezdefino commented on code in PR #21879:
URL: https://github.com/apache/beam/pull/21879#discussion_r897520005


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -628,6 +628,8 @@ Table getTable(
           client
               .tables()
               .get(ref.getProjectId(), ref.getDatasetId(), ref.getTableId())
+              // avoid retrieving the STORAGE_STATS from the table (which is the default option)
+              .set("view", "BASIC")

Review Comment:
   changed the impl to address this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] arunpandianp commented on a diff in pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
arunpandianp commented on code in PR #21879:
URL: https://github.com/apache/beam/pull/21879#discussion_r900486032


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -616,13 +616,24 @@ private DatasetServiceImpl(BigQueryOptions bqOptions) {
     @Override
     public @Nullable Table getTable(TableReference tableRef, List<String> selectedFields)
         throws IOException, InterruptedException {
-      return getTable(tableRef, selectedFields, createDefaultBackoff(), Sleeper.DEFAULT);
+      return getTable(tableRef, selectedFields, TableMetadataView.STORAGE_STATS);

Review Comment:
   are you sure passing STORAGE_STATS will produce the same outputs as not passing anything? If in doubt, it is safe to pass null here and keep the existing behavior as it is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] prodriguezdefino commented on a diff in pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
prodriguezdefino commented on code in PR #21879:
URL: https://github.com/apache/beam/pull/21879#discussion_r900506673


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -616,13 +616,24 @@ private DatasetServiceImpl(BigQueryOptions bqOptions) {
     @Override
     public @Nullable Table getTable(TableReference tableRef, List<String> selectedFields)
         throws IOException, InterruptedException {
-      return getTable(tableRef, selectedFields, createDefaultBackoff(), Sleeper.DEFAULT);
+      return getTable(tableRef, selectedFields, TableMetadataView.STORAGE_STATS);

Review Comment:
   I used the enum value on the default behavior marked on the [api page](https://cloud.google.com/bigquery/docs/reference/rest/v2/tables/get) based on @ayberk comment and for clarity sake. 
   
   JIC I just ran the the requests on a simple table, see below. 
   
   this is the response with unset `view` param: 
   ```{
     "kind": "bigquery#table",
     "etag": "mlPgtbB4NwSxbglNCDXbVg==",
     "id": "pabs-pso-lab:dataflowps2bq.testpubsubbq",
     "selfLink": "https://content-bigquery.googleapis.com/bigquery/v2/projects/pabs-pso-lab/datasets/dataflowps2bq/tables/testpubsubbq",
     "tableReference": {
       "projectId": "pabs-pso-lab",
       "datasetId": "dataflowps2bq",
       "tableId": "testpubsubbq"
     },
     "schema": {
       "fields": [
         {
           "name": "Student_Name",
           "type": "STRING",
           "mode": "REQUIRED"
         }
       ]
     },
     "numBytes": "1000",
     "numLongTermBytes": "1000",
     "numRows": "100",
     "creationTime": "1618523588042",
     "lastModifiedTime": "1618531373191",
     "type": "TABLE",
     "location": "US",
     "numTotalLogicalBytes": "1000",
     "numActiveLogicalBytes": "0",
     "numLongTermLogicalBytes": "1000"
   }
   ```
   
   This setting `STORAGE_STATS` on `view`: 
   ```
   {
     "kind": "bigquery#table",
     "etag": "mlPgtbB4NwSxbglNCDXbVg==",
     "id": "pabs-pso-lab:dataflowps2bq.testpubsubbq",
     "selfLink": "https://content-bigquery.googleapis.com/bigquery/v2/projects/pabs-pso-lab/datasets/dataflowps2bq/tables/testpubsubbq",
     "tableReference": {
       "projectId": "pabs-pso-lab",
       "datasetId": "dataflowps2bq",
       "tableId": "testpubsubbq"
     },
     "schema": {
       "fields": [
         {
           "name": "Student_Name",
           "type": "STRING",
           "mode": "REQUIRED"
         }
       ]
     },
     "numBytes": "1000",
     "numLongTermBytes": "1000",
     "numRows": "100",
     "creationTime": "1618523588042",
     "lastModifiedTime": "1618531373191",
     "type": "TABLE",
     "location": "US",
     "numTotalLogicalBytes": "1000",
     "numActiveLogicalBytes": "0",
     "numLongTermLogicalBytes": "1000"
   }
   ```
   This one when setting `FULL` on `view`: 
   ```
   {
     "kind": "bigquery#table",
     "etag": "mlPgtbB4NwSxbglNCDXbVg==",
     "id": "pabs-pso-lab:dataflowps2bq.testpubsubbq",
     "selfLink": "https://content-bigquery.googleapis.com/bigquery/v2/projects/pabs-pso-lab/datasets/dataflowps2bq/tables/testpubsubbq",
     "tableReference": {
       "projectId": "pabs-pso-lab",
       "datasetId": "dataflowps2bq",
       "tableId": "testpubsubbq"
     },
     "schema": {
       "fields": [
         {
           "name": "Student_Name",
           "type": "STRING",
           "mode": "REQUIRED"
         }
       ]
     },
     "numBytes": "1000",
     "numLongTermBytes": "1000",
     "numRows": "100",
     "creationTime": "1618523588042",
     "lastModifiedTime": "1618531373191",
     "type": "TABLE",
     "location": "US",
     "numTotalLogicalBytes": "1000",
     "numActiveLogicalBytes": "0",
     "numLongTermLogicalBytes": "1000"
   }
   ```
   And this one when using `BASIC` on `view`: 
   ```
   {
     "kind": "bigquery#table",
     "etag": "mlPgtbB4NwSxbglNCDXbVg==",
     "id": "pabs-pso-lab:dataflowps2bq.testpubsubbq",
     "selfLink": "https://content-bigquery.googleapis.com/bigquery/v2/projects/pabs-pso-lab/datasets/dataflowps2bq/tables/testpubsubbq",
     "tableReference": {
       "projectId": "pabs-pso-lab",
       "datasetId": "dataflowps2bq",
       "tableId": "testpubsubbq"
     },
     "schema": {
       "fields": [
         {
           "name": "Student_Name",
           "type": "STRING",
           "mode": "REQUIRED"
         }
       ]
     },
     "creationTime": "1618523588042",
     "type": "TABLE"
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1155884118

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #21879:
URL: https://github.com/apache/beam/pull/21879


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] prodriguezdefino commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
prodriguezdefino commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1156873676

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1155884121

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1159297593

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] prodriguezdefino commented on a diff in pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
prodriguezdefino commented on code in PR #21879:
URL: https://github.com/apache/beam/pull/21879#discussion_r898481245


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServices.java:
##########
@@ -111,6 +111,9 @@ JobStatistics dryRunQuery(
 
   /** An interface to get, create and delete Cloud BigQuery datasets and tables. */
   public interface DatasetService extends AutoCloseable {
+
+    static String TABLE_METADATA_BASIC_VIEW = "BASIC";

Review Comment:
   ok, created the enum and added the STORAGE_STATS to the default request. Kept the null check because the enum params still can be nullable. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] prodriguezdefino commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
prodriguezdefino commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1157097616

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ayberk commented on a diff in pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
ayberk commented on code in PR #21879:
URL: https://github.com/apache/beam/pull/21879#discussion_r897460941


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -628,6 +628,8 @@ Table getTable(
           client
               .tables()
               .get(ref.getProjectId(), ref.getDatasetId(), ref.getTableId())
+              // avoid retrieving the STORAGE_STATS from the table (which is the default option)
+              .set("view", "BASIC")

Review Comment:
   This would be breaking change for anyone using the extra metadata coming from STORAGE_STATS. We should add a new flag/option instead and include a warning about our plan to change the default mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] arunpandianp commented on a diff in pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
arunpandianp commented on code in PR #21879:
URL: https://github.com/apache/beam/pull/21879#discussion_r900507962


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -616,13 +616,24 @@ private DatasetServiceImpl(BigQueryOptions bqOptions) {
     @Override
     public @Nullable Table getTable(TableReference tableRef, List<String> selectedFields)
         throws IOException, InterruptedException {
-      return getTable(tableRef, selectedFields, createDefaultBackoff(), Sleeper.DEFAULT);
+      return getTable(tableRef, selectedFields, TableMetadataView.STORAGE_STATS);

Review Comment:
   ack, thanks 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1155884124

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ayberk commented on a diff in pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
ayberk commented on code in PR #21879:
URL: https://github.com/apache/beam/pull/21879#discussion_r898438085


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServices.java:
##########
@@ -111,6 +111,9 @@ JobStatistics dryRunQuery(
 
   /** An interface to get, create and delete Cloud BigQuery datasets and tables. */
   public interface DatasetService extends AutoCloseable {
+
+    static String TABLE_METADATA_BASIC_VIEW = "BASIC";

Review Comment:
   I'd create an enum to represent this and pass the default one we have (STATS) explicitly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1159204867

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #21879: Adding the BASIC view setting to getTable request

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21879:
URL: https://github.com/apache/beam/pull/21879#issuecomment-1159303416

   LGTM will merge once precommit passes 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org