You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Steve Loughran <st...@hortonworks.com> on 2017/01/18 11:10:16 UTC

can someone review my PR?

I've had a PR outstanding on spark/object store integration, works for both maven and sbt builds

https://issues.apache.org/jira/browse/SPARK-7481
https://github.com/apache/spark/pull/12004

Can I get someone to review this as it appears to be being overlooked amongst all the PRs

thanks

-steve

Re: can someone review my PR?

Posted by Marcelo Vanzin <va...@cloudera.com>.
On Wed, Jan 18, 2017 at 6:16 AM, Steve Loughran <st...@hortonworks.com> wrote:
> it's failing on the dependency check as the dependencies have changed.
> that's what it's meant to do. should I explicitly be changing the values so
> that the build doesn't notice the change?

Yes. There's no automated way to do that, intentionally.

-- 
Marcelo

---------------------------------------------------------------------
To unsubscribe e-mail: dev-unsubscribe@spark.apache.org


Re: can someone review my PR?

Posted by Steve Loughran <st...@hortonworks.com>.
On 18 Jan 2017, at 11:18, Sean Owen <so...@cloudera.com>> wrote:

It still doesn't pass tests -- I'd usually not look until that point.

it's failing on the dependency check as the dependencies have changed. that's what it's meant to do. should I explicitly be changing the values so that the build doesn't notice the change?

On Wed, Jan 18, 2017 at 11:10 AM Steve Loughran <st...@hortonworks.com>> wrote:
I've had a PR outstanding on spark/object store integration, works for both maven and sbt builds

https://issues.apache.org/jira/browse/SPARK-7481
https://github.com/apache/spark/pull/12004

Can I get someone to review this as it appears to be being overlooked amongst all the PRs

thanks

-steve


Re: can someone review my PR?

Posted by Sean Owen <so...@cloudera.com>.
It still doesn't pass tests -- I'd usually not look until that point.

On Wed, Jan 18, 2017 at 11:10 AM Steve Loughran <st...@hortonworks.com>
wrote:

> I've had a PR outstanding on spark/object store integration, works for
> both maven and sbt builds
>
> https://issues.apache.org/jira/browse/SPARK-7481
> https://github.com/apache/spark/pull/12004
>
> Can I get someone to review this as it appears to be being overlooked
> amongst all the PRs
>
> thanks
>
> -steve
>