You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/03 05:30:38 UTC
[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #353:
[ISSUE #352]feat: use jsoniter to replace with json
xujianhai666 opened a new pull request #353: [ISSUE #352]feat: use jsoniter to replace with json
URL: https://github.com/apache/rocketmq-client-go/pull/353
jsoniter is high-perfermance json lib, json use lots of cpu, which could be saved by jsontier.
Closes #352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #353: [ISSUE
#352]feat: use jsoniter to replace with json
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #353: [ISSUE #352]feat: use jsoniter to replace with json
URL: https://github.com/apache/rocketmq-client-go/pull/353#issuecomment-570467895
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=h1) Report
> Merging [#353](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/598c979ebd6db2212776e8e38d7f623090360481?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `53.84%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #353 +/- ##
==========================================
+ Coverage 26.28% 26.35% +0.07%
==========================================
Files 47 47
Lines 5535 5535
==========================================
+ Hits 1455 1459 +4
+ Misses 3889 3885 -4
Partials 191 191
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/353/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.31% <0%> (ø)` | :arrow_up: |
| [consumer/consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/353/diff?src=pr&el=tree#diff-Y29uc3VtZXIvY29uc3VtZXIuZ28=) | `18.84% <0%> (ø)` | :arrow_up: |
| [internal/model.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/353/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbW9kZWwuZ28=) | `46.73% <0%> (ø)` | :arrow_up: |
| [internal/remote/codec.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/353/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL2NvZGVjLmdv) | `60.08% <100%> (+1.64%)` | :arrow_up: |
| [consumer/offset\_store.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/353/diff?src=pr&el=tree#diff-Y29uc3VtZXIvb2Zmc2V0X3N0b3JlLmdv) | `64.67% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=footer). Last update [598c979...b0a303a](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang merged pull request #353: [ISSUE
#352]feat: use jsoniter to replace with json
Posted by GitBox <gi...@apache.org>.
wenfengwang merged pull request #353: [ISSUE #352]feat: use jsoniter to replace with json
URL: https://github.com/apache/rocketmq-client-go/pull/353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #353:
[ISSUE #352]feat: use jsoniter to replace with json
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #353: [ISSUE #352]feat: use jsoniter to replace with json
URL: https://github.com/apache/rocketmq-client-go/pull/353#issuecomment-570467895
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=h1) Report
> Merging [#353](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/598c979ebd6db2212776e8e38d7f623090360481?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `53.84%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #353 +/- ##
==========================================
+ Coverage 26.28% 26.35% +0.07%
==========================================
Files 47 47
Lines 5535 5535
==========================================
+ Hits 1455 1459 +4
+ Misses 3889 3885 -4
Partials 191 191
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/353/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.31% <0%> (ø)` | :arrow_up: |
| [consumer/consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/353/diff?src=pr&el=tree#diff-Y29uc3VtZXIvY29uc3VtZXIuZ28=) | `18.84% <0%> (ø)` | :arrow_up: |
| [internal/model.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/353/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbW9kZWwuZ28=) | `46.73% <0%> (ø)` | :arrow_up: |
| [internal/remote/codec.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/353/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL2NvZGVjLmdv) | `60.08% <100%> (+1.64%)` | :arrow_up: |
| [consumer/offset\_store.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/353/diff?src=pr&el=tree#diff-Y29uc3VtZXIvb2Zmc2V0X3N0b3JlLmdv) | `64.67% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=footer). Last update [598c979...b0a303a](https://codecov.io/gh/apache/rocketmq-client-go/pull/353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services