You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2012/02/28 10:52:32 UTC

git commit: Replace the hacky string with a simpler constant that does the same.

Updated Branches:
  refs/heads/master dca089865 -> 7477ef478


Replace the hacky string with a simpler constant that does the same.

suggested-by: cleiter (irc)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7477ef47
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7477ef47
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7477ef47

Branch: refs/heads/master
Commit: 7477ef47847bab81461bdd6432951b5bbaffbd15
Parents: dca0898
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Tue Feb 28 11:52:17 2012 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Tue Feb 28 11:52:17 2012 +0200

----------------------------------------------------------------------
 .../request/resource/PackageResourceReference.java |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/7477ef47/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java b/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java
index 90ae92e..6cb8d10 100644
--- a/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java
+++ b/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java
@@ -54,8 +54,8 @@ public class PackageResourceReference extends ResourceReference
 	/**
 	 * A constant used to indicate that there is no minified version of the resource.
 	 */
-	// Any file system wont allow a file with this name, so there wont be clashes.
-	private static final String NO_MINIFIED_NAME = "~!@#$%^&*()_+<>?|}";
+	// WARNING: always compare by identity!
+	private static final String NO_MINIFIED_NAME = new String();
 
 	/**
 	 * Construct.
@@ -167,7 +167,7 @@ public class PackageResourceReference extends ResourceReference
 
 	/**
 	 * Initializes the cache for the existence of the minified resource.
-	 * @return the name of the minified resource or the special constant {@value #NO_MINIFIED_NAME}
+	 * @return the name of the minified resource or the special constant {@link #NO_MINIFIED_NAME}
 	 * if there is no minified version
 	 */
 	private String internalGetMinifiedName()