You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by Yu Ding <no...@github.com.INVALID> on 2022/02/02 23:26:06 UTC

[apache/incubator-teaclave] fix: code coverage report generation (PR #606)

## Description

Code coverage report generation has been stopped for a while due to toolchain upgrade. This PR fixes the report generation command `cmake -DCOV=ON` and `make cov`

Please release a set of build image after the merge.

Fixes # (issue)

## Type of change (select or add applied and delete the others)

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [x] Code cleanup or just sync with upstream third-party crates

## How has this been tested?

Code coverage report has been generated successfully at https://gist.github.com/dingelish/186ecb02002bb273a47e0cbfd1196483

## Checklist

- [x] Fork the repo and create your branch from `master`.
- [x] If you&#39;ve added code that should be tested, add tests.
- [x] If you&#39;ve changed APIs, update the documentation.
- [x] Ensure the tests pass (see CI results).
- [x] Make sure your code lints/format.

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave/pull/606

-- Commit Summary --

  * fix: code coverage report generation

-- File Changes --

    M cmake/scripts/gen_cov.sh (2)
    M docker/build.ubuntu-1804.sgx-2.14.Dockerfile (7)
    M docker/build.ubuntu-1804.sgx-dcap-1.11.Dockerfile (7)
    M docker/build.ubuntu-2004.sgx-2.15.1.Dockerfile (7)
    M docker/build.ubuntu-2004.sgx-dcap-1.12.1.Dockerfile (7)
    M third_party/crates-sgx (2)

-- Patch Links --

https://github.com/apache/incubator-teaclave/pull/606.patch
https://github.com/apache/incubator-teaclave/pull/606.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/606
You are receiving this because you are subscribed to this thread.

Message ID: &lt;apache/incubator-teaclave/pull/606@github.com&gt;

Re: [apache/incubator-teaclave] fix: code coverage report generation (PR #606)

Posted by Mingshen Sun <no...@github.com.INVALID>.
Merged #606 into yu-fix-cov.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/606#event-6000021413
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/incubator-teaclave] fix: code coverage report generation (PR #606)

Posted by Yu Ding <no...@github.com.INVALID>.
rebased on #606 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/606#issuecomment-1028511155
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/incubator-teaclave] fix: code coverage report generation (PR #606)

Posted by Yu Ding <no...@github.com.INVALID>.
TVM build failed. Upstream fix is https://github.com/apache/tvm/pull/10147

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/606#issuecomment-1028475218
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>