You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/23 23:24:46 UTC

[GitHub] [pulsar] bharanic-dev commented on a change in pull request #11732: [ PIP-82] [pulsar-broker] Fix a couple of issues

bharanic-dev commented on a change in pull request #11732:
URL: https://github.com/apache/pulsar/pull/11732#discussion_r694373441



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupPublishLimiter.java
##########
@@ -160,12 +168,22 @@ private void replaceLimiters(Runnable updater) {
 
     @Override
     public void close() {
-      this.apply();
-      replaceLimiters(null);
+        replaceLimiters(null);

Review comment:
       @cckellogg thank you. I added the comment. I also fixed the case where the callback was not getting called when ratelimiter is closed (not invoking the callback can leave the producer blocked forever). PTAL.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org