[GitHub] abaruni commented on a change in pull request #217: Add ability to get trigger configuration and status

[gi...@git.apache.org]

abaruni commented on a change in pull request #217: Add ability to get trigger configuration and status
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144406862
 
 

 ##########
 File path: action/kafkaFeedWeb.js
 ##########
 @@ -61,6 +61,35 @@ function main(params) {
 
                     resolve(common.webResponse(statusCode, body));
                 });
+        } else if (params.__ow_method === "get") {
 
 Review comment:
   you'll notice the code between messageHubFeedWeb.js and kafkaFeedWeb.js is entirely duplicated. i think it's definitely fair to get rid of the duplication. but i don't this this is the the place to do it. it should be done under a different issue/epic
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services