You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jd...@apache.org on 2009/04/28 16:09:20 UTC
svn commit: r769417 - in /maven/components/branches/maven-2.1.x: ./
maven-artifact-manager/
maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/
maven-core/ maven-core/src/main/resources/META-INF/plexus/
Author: jdcasey
Date: Tue Apr 28 14:09:19 2009
New Revision: 769417
URL: http://svn.apache.org/viewvc?rev=769417&view=rev
Log:
update to use http wagon instead of lightweight http wagon, since httpclient is already present for use in the webdav wagon.
Modified:
maven/components/branches/maven-2.1.x/maven-artifact-manager/pom.xml
maven/components/branches/maven-2.1.x/maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java
maven/components/branches/maven-2.1.x/maven-core/pom.xml
maven/components/branches/maven-2.1.x/maven-core/src/main/resources/META-INF/plexus/components.xml
maven/components/branches/maven-2.1.x/pom.xml
Modified: maven/components/branches/maven-2.1.x/maven-artifact-manager/pom.xml
URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.1.x/maven-artifact-manager/pom.xml?rev=769417&r1=769416&r2=769417&view=diff
==============================================================================
--- maven/components/branches/maven-2.1.x/maven-artifact-manager/pom.xml (original)
+++ maven/components/branches/maven-2.1.x/maven-artifact-manager/pom.xml Tue Apr 28 14:09:19 2009
@@ -42,7 +42,7 @@
</dependency>
<dependency>
<groupId>org.apache.maven.wagon</groupId>
- <artifactId>wagon-http-lightweight</artifactId>
+ <artifactId>wagon-http</artifactId>
<scope>test</scope>
</dependency>
<dependency>
Modified: maven/components/branches/maven-2.1.x/maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java
URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.1.x/maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java?rev=769417&r1=769416&r2=769417&view=diff
==============================================================================
--- maven/components/branches/maven-2.1.x/maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java (original)
+++ maven/components/branches/maven-2.1.x/maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java Tue Apr 28 14:09:19 2009
@@ -34,7 +34,7 @@
import org.apache.maven.wagon.TransferFailedException;
import org.apache.maven.wagon.UnsupportedProtocolException;
import org.apache.maven.wagon.Wagon;
-import org.apache.maven.wagon.providers.http.LightweightHttpWagon;
+import org.apache.maven.wagon.providers.http.HttpWagon;
import org.apache.maven.wagon.repository.Repository;
import org.codehaus.plexus.PlexusTestCase;
import org.codehaus.plexus.util.FileUtils;
@@ -420,7 +420,7 @@
private void runThread()
throws Exception
{
- LightweightHttpWagon wagon = (LightweightHttpWagon) wagonManager.getWagon( repository );
+ HttpWagon wagon = (HttpWagon) wagonManager.getWagon( repository );
assertEquals( TEST_USER_AGENT, wagon.getHttpHeaders().getProperty( "User-Agent" ) );
container.release( wagon );
}
Modified: maven/components/branches/maven-2.1.x/maven-core/pom.xml
URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.1.x/maven-core/pom.xml?rev=769417&r1=769416&r2=769417&view=diff
==============================================================================
--- maven/components/branches/maven-2.1.x/maven-core/pom.xml (original)
+++ maven/components/branches/maven-2.1.x/maven-core/pom.xml Tue Apr 28 14:09:19 2009
@@ -51,7 +51,7 @@
</dependency>
<dependency>
<groupId>org.apache.maven.wagon</groupId>
- <artifactId>wagon-http-lightweight</artifactId>
+ <artifactId>wagon-http</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
Modified: maven/components/branches/maven-2.1.x/maven-core/src/main/resources/META-INF/plexus/components.xml
URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.1.x/maven-core/src/main/resources/META-INF/plexus/components.xml?rev=769417&r1=769416&r2=769417&view=diff
==============================================================================
--- maven/components/branches/maven-2.1.x/maven-core/src/main/resources/META-INF/plexus/components.xml (original)
+++ maven/components/branches/maven-2.1.x/maven-core/src/main/resources/META-INF/plexus/components.xml Tue Apr 28 14:09:19 2009
@@ -619,5 +619,7 @@
<_configuration-file>~/.m2/settings-security.xml</_configuration-file>
</configuration>
</component>
+<!--
+ -->
</components>
</component-set>
Modified: maven/components/branches/maven-2.1.x/pom.xml
URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.1.x/pom.xml?rev=769417&r1=769416&r2=769417&view=diff
==============================================================================
--- maven/components/branches/maven-2.1.x/pom.xml (original)
+++ maven/components/branches/maven-2.1.x/pom.xml Tue Apr 28 14:09:19 2009
@@ -411,7 +411,7 @@
<dependency>
<groupId>commons-cli</groupId>
<artifactId>commons-cli</artifactId>
- <version>1.0</version>
+ <version>1.2</version>
</dependency>
<dependency>
<groupId>org.apache.maven.doxia</groupId>
@@ -471,7 +471,7 @@
</dependency>
<dependency>
<groupId>org.apache.maven.wagon</groupId>
- <artifactId>wagon-http-lightweight</artifactId>
+ <artifactId>wagon-http</artifactId>
<version>${wagonVersion}</version>
</dependency>
<dependency>
Re: svn commit: r769417 - in /maven/components/branches/maven-2.1.x:
./ maven-artifact-manager/ maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/
maven-core/ maven-core/src/main/resources/META-INF/plexus/
Posted by John Casey <jd...@commonjava.org>.
<wishlist>
It'd be nice if we could just use a different component repository or
something that was sensitive to a properties file. This custom component
repository (an actual thing in plexus right now, but with only one impl)
might use the properties file to read which role-hint to use as the
'default' hint for a particular role...or, to provide a mapping from an
abstract role-hint to a concrete one.
If we could do this, it'd be a simple matter of telling users to set:
org.apache.maven.wagon.Wagon.http=http-lightweight
in that properties file. This is the component selector we've talked
about intermittently in the Plexus community, and it seems like it'd be
relatively simple to implement using this approach.
Oh well, maybe someday. :)
</wishlist>
-john
Brett Porter wrote:
>
> On 29/04/2009, at 9:25 AM, Brian Fox wrote:
>
>> Besides inertial friction to a change, is there a specific reason not
>> to consolidate on a single http provider? We already know that people
>> may use the dav wagon simply to handle larger artifacts and such, it
>> seems like reducing our surface area here would help
>>
>> I wouldn't be opposed to allowing some selection mechanism, but
>> telling tons of users to switch from the familiar http:// url is just
>> going to confuse them.
>
> That's not what I was suggesting. I'm saying switch to httpclient-based
> wagon, make sure lightweight works through an extension and a different
> protocol in the odd event the other doesn't work for them. I'd be
> concerned if we amassed the 10-15 users required to reach a ton using
> that option.
>
> I'm having serious deja vu, since we went through all this in the Maven
> 1.0 days already :)
>
> Cheers,
> Brett
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r769417 - in /maven/components/branches/maven-2.1.x: ./ maven-artifact-manager/ maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/ maven-core/ maven-core/src/main/resources/META-INF/plexus/
Posted by Brett Porter <br...@apache.org>.
On 29/04/2009, at 9:25 AM, Brian Fox wrote:
> Besides inertial friction to a change, is there a specific reason
> not to consolidate on a single http provider? We already know that
> people may use the dav wagon simply to handle larger artifacts and
> such, it seems like reducing our surface area here would help
>
> I wouldn't be opposed to allowing some selection mechanism, but
> telling tons of users to switch from the familiar http:// url is
> just going to confuse them.
That's not what I was suggesting. I'm saying switch to httpclient-
based wagon, make sure lightweight works through an extension and a
different protocol in the odd event the other doesn't work for them.
I'd be concerned if we amassed the 10-15 users required to reach a ton
using that option.
I'm having serious deja vu, since we went through all this in the
Maven 1.0 days already :)
Cheers,
Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r769417 - in /maven/components/branches/maven-2.1.x:
./ maven-artifact-manager/ maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/
maven-core/ maven-core/src/main/resources/META-INF/plexus/
Posted by Brian Fox <br...@infinity.nu>.
Besides inertial friction to a change, is there a specific reason not to
consolidate on a single http provider? We already know that people may
use the dav wagon simply to handle larger artifacts and such, it seems
like reducing our surface area here would help
I wouldn't be opposed to allowing some selection mechanism, but telling
tons of users to switch from the familiar http:// url is just going to
confuse them.
Brett Porter wrote:
>
> On 29/04/2009, at 4:15 AM, Brett Porter wrote:
>
>> On 29/04/2009, at 1:37 AM, John Casey wrote:
>>
>>> I'll file the issue, but we've come across a problem where long
>>> passwords cause Sun's Base64 implementation to line-wrap the
>>> Authorization HTTP header.
>>>
>>> I've done extensive testing on this in our internal code, and found
>>> that httpclient works perfectly on the same cases.
>>
>> Got it. We might want to extend the RC cycle and limit any other
>> changes to artifact handling to avoid question with might cause
>> problems.
>>
>> Is it possible to add an IT for the original problem by checking the
>> header on the server side?
>>
>> Another thing worth looking at is a config option that can flip
>> implementations, though it might be tricky since I think the wagons
>> use the same role hint.
>
> Further option to this: we could add additional role-hints (like in
> the dav wagon) so that you can choose which implementation to use in
> case of problems (it'd also need to be added as an extension).
>
> Note that your specific issue can probably be worked around by using a
> dav:// URL instead of http:// on an unmodified 2.1.0.
>
> Cheers,
> Brett
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r769417 - in /maven/components/branches/maven-2.1.x: ./ maven-artifact-manager/ maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/ maven-core/ maven-core/src/main/resources/META-INF/plexus/
Posted by Brett Porter <br...@apache.org>.
On 29/04/2009, at 4:15 AM, Brett Porter wrote:
> On 29/04/2009, at 1:37 AM, John Casey wrote:
>
>> I'll file the issue, but we've come across a problem where long
>> passwords cause Sun's Base64 implementation to line-wrap the
>> Authorization HTTP header.
>>
>> I've done extensive testing on this in our internal code, and found
>> that httpclient works perfectly on the same cases.
>
> Got it. We might want to extend the RC cycle and limit any other
> changes to artifact handling to avoid question with might cause
> problems.
>
> Is it possible to add an IT for the original problem by checking the
> header on the server side?
>
> Another thing worth looking at is a config option that can flip
> implementations, though it might be tricky since I think the wagons
> use the same role hint.
Further option to this: we could add additional role-hints (like in
the dav wagon) so that you can choose which implementation to use in
case of problems (it'd also need to be added as an extension).
Note that your specific issue can probably be worked around by using a
dav:// URL instead of http:// on an unmodified 2.1.0.
Cheers,
Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r769417 - in /maven/components/branches/maven-2.1.x: ./ maven-artifact-manager/ maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/ maven-core/ maven-core/src/main/resources/META-INF/plexus/
Posted by Brett Porter <br...@apache.org>.
On 29/04/2009, at 1:37 AM, John Casey wrote:
> I'll file the issue, but we've come across a problem where long
> passwords cause Sun's Base64 implementation to line-wrap the
> Authorization HTTP header.
>
> I've done extensive testing on this in our internal code, and found
> that httpclient works perfectly on the same cases.
Got it. We might want to extend the RC cycle and limit any other
changes to artifact handling to avoid question with might cause
problems.
Is it possible to add an IT for the original problem by checking the
header on the server side?
Another thing worth looking at is a config option that can flip
implementations, though it might be tricky since I think the wagons
use the same role hint.
Cheers,
Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r769417 - in /maven/components/branches/maven-2.1.x:
./ maven-artifact-manager/ maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/
maven-core/ maven-core/src/main/resources/META-INF/plexus/
Posted by John Casey <jd...@commonjava.org>.
I'll file the issue, but we've come across a problem where long
passwords cause Sun's Base64 implementation to line-wrap the
Authorization HTTP header.
I've done extensive testing on this in our internal code, and found that
httpclient works perfectly on the same cases.
-john
Brett Porter wrote:
>
> On 29/04/2009, at 12:09 AM, jdcasey@apache.org wrote:
>
>> URL: http://svn.apache.org/viewvc?rev=769417&view=rev
>> Log:
>> update to use http wagon instead of lightweight http wagon, since
>> httpclient is already present for use in the webdav wagon.
>
> I'm not sure about this - couldn't this have some other side effects? Is
> there a reason, jira to use it other than because we can?
>>
>> Modified:
>> maven/components/branches/maven-2.1.x/maven-core/src/main/resources/META-INF/plexus/components.xml
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/components/branches/maven-2.1.x/maven-core/src/main/resources/META-INF/plexus/components.xml?rev=769417&r1=769416&r2=769417&view=diff
>>
>> ==============================================================================
>>
>> ---
>> maven/components/branches/maven-2.1.x/maven-core/src/main/resources/META-INF/plexus/components.xml
>> (original)
>> +++
>> maven/components/branches/maven-2.1.x/maven-core/src/main/resources/META-INF/plexus/components.xml
>> Tue Apr 28 14:09:19 2009
>> @@ -619,5 +619,7 @@
>>
>> <_configuration-file>~/.m2/settings-security.xml</_configuration-file>
>> </configuration>
>> </component>
>> +<!--
>> + -->
>> </components>
>> </component-set>
>>
>> Modified: maven/components/branches/maven-2.1.x/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/maven/components/branches/maven-2.1.x/pom.xml?rev=769417&r1=769416&r2=769417&view=diff
>>
>> ==============================================================================
>>
>> --- maven/components/branches/maven-2.1.x/pom.xml (original)
>> +++ maven/components/branches/maven-2.1.x/pom.xml Tue Apr 28 14:09:19
>> 2009
>> @@ -411,7 +411,7 @@
>> <dependency>
>> <groupId>commons-cli</groupId>
>> <artifactId>commons-cli</artifactId>
>> - <version>1.0</version>
>> + <version>1.2</version>
>> </dependency>
>> <dependency>
>> <groupId>org.apache.maven.doxia</groupId>
>> @@ -471,7 +471,7 @@
>> </dependency>
>> <dependency>
>
> two stray changes got rolled in here too.
>
> - Brett
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r769417 - in /maven/components/branches/maven-2.1.x: ./ maven-artifact-manager/ maven-artifact-manager/src/test/java/org/apache/maven/artifact/manager/ maven-core/ maven-core/src/main/resources/META-INF/plexus/
Posted by Brett Porter <br...@apache.org>.
On 29/04/2009, at 12:09 AM, jdcasey@apache.org wrote:
> URL: http://svn.apache.org/viewvc?rev=769417&view=rev
> Log:
> update to use http wagon instead of lightweight http wagon, since
> httpclient is already present for use in the webdav wagon.
I'm not sure about this - couldn't this have some other side effects?
Is there a reason, jira to use it other than because we can?
>
> Modified: maven/components/branches/maven-2.1.x/maven-core/src/main/
> resources/META-INF/plexus/components.xml
> URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.1.x/maven-core/src/main/resources/META-INF/plexus/components.xml?rev=769417&r1=769416&r2=769417&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- maven/components/branches/maven-2.1.x/maven-core/src/main/
> resources/META-INF/plexus/components.xml (original)
> +++ maven/components/branches/maven-2.1.x/maven-core/src/main/
> resources/META-INF/plexus/components.xml Tue Apr 28 14:09:19 2009
> @@ -619,5 +619,7 @@
> <_configuration-file>~/.m2/settings-security.xml</
> _configuration-file>
> </configuration>
> </component>
> +<!--
> + -->
> </components>
> </component-set>
>
> Modified: maven/components/branches/maven-2.1.x/pom.xml
> URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.1.x/pom.xml?rev=769417&r1=769416&r2=769417&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- maven/components/branches/maven-2.1.x/pom.xml (original)
> +++ maven/components/branches/maven-2.1.x/pom.xml Tue Apr 28
> 14:09:19 2009
> @@ -411,7 +411,7 @@
> <dependency>
> <groupId>commons-cli</groupId>
> <artifactId>commons-cli</artifactId>
> - <version>1.0</version>
> + <version>1.2</version>
> </dependency>
> <dependency>
> <groupId>org.apache.maven.doxia</groupId>
> @@ -471,7 +471,7 @@
> </dependency>
> <dependency>
two stray changes got rolled in here too.
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org