You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@johnzon.apache.org by "SingingBush (via GitHub)" <gi...@apache.org> on 2023/01/26 10:21:41 UTC

[GitHub] [johnzon] SingingBush commented on a diff in pull request #99: JOHNZON-305 : Java Modules

SingingBush commented on code in PR #99:
URL: https://github.com/apache/johnzon/pull/99#discussion_r1087650145


##########
johnzon-jsonb/pom.xml:
##########
@@ -144,6 +144,7 @@
         <artifactId>maven-bundle-plugin</artifactId>
         <configuration>
           <instructions>
+            <Automatic-Module-Name>johnzon.jsonb</Automatic-Module-Name>

Review Comment:
   yes using a module-info file is a better option if possible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org