You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "bknbkn (via GitHub)" <gi...@apache.org> on 2024/10/24 08:25:10 UTC
[PR] Core: Fix drop partition field and schema field error [iceberg]
bknbkn opened a new pull request, #11387:
URL: https://github.com/apache/iceberg/pull/11387
fix #11314
In the previous code, each spec reads the latest schema. After deleting the corresponding field, the historical spec cannot find the corresponding field in the current schema, and an error will occur.
This patch **persist the schema id corresponding to the spec. The historical spec can read the corresponding schema, and the current spec will be updated to the current schema**
But even if the partition field is deleted in the V1 table, it will not be deleted in the spec. Therefore, the latest spec is not compatible with the schema after the field is deleted. So I prefer to forbid the V1 table from deleting the existing partition field (by Partition#checkCompatibility method guarantee)
For V2 tables, it is safe to delete the corresponding column after deleting the partition field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix drop partition field and schema field error [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #11387: Core: Fix drop partition field and schema field error
URL: https://github.com/apache/iceberg/pull/11387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix drop partition field and schema field error [iceberg]
Posted by "bknbkn (via GitHub)" <gi...@apache.org>.
bknbkn commented on PR #11387:
URL: https://github.com/apache/iceberg/pull/11387#issuecomment-2435252649
cc @Fokko @nastra @amogh-jahagirdar Do you have time to help review it? Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix drop partition field and schema field error [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11387:
URL: https://github.com/apache/iceberg/pull/11387#issuecomment-2495713891
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Fix drop partition field and schema field error [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11387:
URL: https://github.com/apache/iceberg/pull/11387#issuecomment-2509489562
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org