You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "lordcheng10 (via GitHub)" <gi...@apache.org> on 2023/06/07 06:51:31 UTC
[GitHub] [inlong] lordcheng10 opened a new pull request, #8174: [INLONG-8173][Sort] Fix the NPE problem when adding new columns
lordcheng10 opened a new pull request, #8174:
URL: https://github.com/apache/inlong/pull/8174
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes https://github.com/apache/inlong/issues/8173
### Motivation
When Column#position may be null, the doAddColumn method may throw an exception:
https://github.com/apache/inlong/blob/a38bab22169a06010c54b0d27ed3b40656c667e6/inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/schema/IcebergSchemaChangeHelper.java#L134-L136
### Modifications
When Column#position is null, append to the last column by default.
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] lordcheng10 commented on pull request #8174: [INLONG-8173][Sort] Fix the NPE problem when adding new columns
Posted by "lordcheng10 (via GitHub)" <gi...@apache.org>.
lordcheng10 commented on PR #8174:
URL: https://github.com/apache/inlong/pull/8174#issuecomment-1580083943
@gong @EMsnap @yunqingmoswu PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #8174: [INLONG-8173][Sort] Fix the NPE problem when adding new columns
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #8174:
URL: https://github.com/apache/inlong/pull/8174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org