You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by gaohoward <gi...@git.apache.org> on 2018/06/07 15:39:11 UTC

[GitHub] activemq-artemis pull request #2128: ARTEMIS-1916 Remove Jmx ArtemisRMIServe...

GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2128

    ARTEMIS-1916 Remove Jmx ArtemisRMIServerSocketFactory

    The ArtemisRMIServerSocketFactory doesn't do anything special,
    instead the existence of this impl class causes jmx client
    failed to connect (for reason not known, probably not fully
    implemented the functionality). It turns out just fine
    to use JDK's impl. This class is not necessary.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis b_artemis1916

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2128
    
----
commit 7d7c6ae193dcfd91bb5a4bd3e0de8542010554fd
Author: Howard Gao <ho...@...>
Date:   2018-06-07T15:29:29Z

    ARTEMIS-1916 Remove Jmx ArtemisRMIServerSocketFactory
    
    The ArtemisRMIServerSocketFactory doesn't do anything special,
    instead the existence of this impl class causes jmx client
    failed to connect (for reason not known, probably not fully
    implemented the functionality). It turns out just fine
    to use JDK's impl. This class is not necessary.

----


---

[GitHub] activemq-artemis issue #2128: ARTEMIS-1916 Remove Jmx ArtemisRMIServerSocket...

Posted by gaohoward <gi...@git.apache.org>.

Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2128
  
    @clebertsuconic I split it because Martyn suggested that this doesn't belong to a test PR. (see Martyn's comment)


---

[GitHub] activemq-artemis issue #2128: ARTEMIS-1916 Remove Jmx ArtemisRMIServerSocket...

Posted by andytaylor <gi...@git.apache.org>.

Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2128
  
    I would create a single PR.
    
    Also Im not sure this is a complete fix. There is still code in there that sets up an SSL socket layer. 
    
    Also I think we need to understand why the code as is doesn't work


---

[GitHub] activemq-artemis issue #2128: ARTEMIS-1916 Remove Jmx ArtemisRMIServerSocket...

Posted by gaohoward <gi...@git.apache.org>.

Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2128
  
    Closing this PR as it's a non issue. 


---

[GitHub] activemq-artemis issue #2128: ARTEMIS-1916 Remove Jmx ArtemisRMIServerSocket...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2128
  
    You have 2 PRs open for JMX why not use a single one?


---

[GitHub] activemq-artemis pull request #2128: ARTEMIS-1916 Remove Jmx ArtemisRMIServe...

Posted by gaohoward <gi...@git.apache.org>.

Github user gaohoward closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2128


---