You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "rp- (via GitHub)" <gi...@apache.org> on 2025/02/03 16:46:37 UTC
[PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
rp- opened a new pull request, #10317:
URL: https://github.com/apache/cloudstack/pull/10317
### Description
Pre-seeded template storages always had there pre initialized 0 sizes and would never be updated. This updates the sizes from the template.properties files on the validateIfSeeded check.
The issue was found while reviewing #10132
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Started a fresh KVM cluster with preseeded systemvm template from `cloud-install-sys-tmplt` on Linstor primary storage.
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "rp- (via GitHub)" <gi...@apache.org>.
rp- commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2636655482
> [SF] Trillian test result (tid-12295) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 47219 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10317-t12295-kvm-ol8.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
>
> Test Result Time (s) Test File
> test_12_start_vm_multiple_volumes_allocated `Error` 15.21 test_vm_life_cycle.py
Hmm as far as I see the fail comes from a VM `i-250-346-VM` that couldn't be found in the database?
Not sure if this can be related to this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2633303239
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2633495591
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "rp- (via GitHub)" <gi...@apache.org>.
rp- commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2633094279
> @rp- this seems to be an issue with the script `cloud-install-sys-tmplt` , right ?
not directly, as the script only updates the `vm_template` table and before cloudstack-management hasn't upgraded all the sql, there isn't even a table `template_store_ref` yet. So you can only fix that issue within the code.
There is this code here: https://github.com/apache/cloudstack/blob/cd81398cb7176698196f72002df5d6088befbaed/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java#L1242
Which does add the seeded entries, but at that time, no secondary storage is mounted, so you can't get the correct sizes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2633308002
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2633493992
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2631551403
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10317?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.29%. Comparing base [(`c1bc57b`)](https://app.codecov.io/gh/apache/cloudstack/commit/c1bc57b844b64bb9f7602567156cfb25f41a8cee?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`ca6c865`)](https://app.codecov.io/gh/apache/cloudstack/commit/ca6c865a0f69d0405bc6e2985fb525437af9d2b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (c1bc57b) and HEAD (ca6c865). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (c1bc57b) | HEAD (ca6c865) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.19 #10317 +/- ##
=============================================
- Coverage 15.16% 4.29% -10.87%
=============================================
Files 5408 366 -5042
Lines 473931 29605 -444326
Branches 57844 5194 -52650
=============================================
- Hits 71866 1272 -70594
+ Misses 394034 28188 -365846
+ Partials 8031 145 -7886
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10317/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10317?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2635429886
<b>[SF] Trillian test result (tid-12295)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47219 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10317-t12295-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_12_start_vm_multiple_volumes_allocated | `Error` | 15.21 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2633497467
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2633313713
> > @rp- this seems to be an issue with the script `cloud-install-sys-tmplt` , right ?
>
> not directly, as the script only updates the `vm_template` table and before cloudstack-management hasn't upgraded all the sql, there isn't even a table `template_store_ref` yet. So you can only fix that issue within the code.
>
> There is this code here:
>
> https://github.com/apache/cloudstack/blob/cd81398cb7176698196f72002df5d6088befbaed/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java#L1242
>
> Which does add the seeded entries, but at that time, no secondary storage is mounted, so you can't get the correct sizes.
thanks @rp-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2633071112
@rp-
this seems to be an issue with the script `cloud-install-sys-tmplt` , right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10317:
URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2636682879
> > [SF] Trillian test result (tid-12295) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 47219 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10317-t12295-kvm-ol8.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
> > Test Result Time (s) Test File
> > test_12_start_vm_multiple_volumes_allocated `Error` 15.21 test_vm_life_cycle.py
>
> Hmm as far as I see the fail comes from a VM `i-250-346-VM` that couldn't be found in the database? Not sure if this can be related to this change?
@rp-
ignore the failure. it is addressed in #10323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org