[GitHub] [logging-log4j2] garydgregory commented on a diff in pull request #1222: Use setters for builder classes

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory commented on code in PR #1222:
URL: https://github.com/apache/logging-log4j2/pull/1222#discussion_r1083872749


##########
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/nosql/NoSqlAppender.java:
##########
@@ -74,9 +74,6 @@ public NoSqlAppender build() {
 
             final NoSqlDatabaseManager<?> manager = NoSqlDatabaseManager.getNoSqlDatabaseManager(managerName,
                     bufferSize, provider);
-            if (manager == null) {
-                return null;
-            }

Review Comment:
   It must be there for a reason but we don't have a unit test that fails without it maybe. It might have  to do with the reconnection logic which can be hard to test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org