[GitHub] [arrow] westonpace commented on a change in pull request #11991: ARROW-13554: [C++] Remove deprecated Scanner::Scan

[GitBox <gi...@apache.org>]

westonpace commented on a change in pull request #11991:
URL: https://github.com/apache/arrow/pull/11991#discussion_r778475838



##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -2239,10 +2233,6 @@ cdef class Scanner(_Weakrefable):
     use_threads : bool, default True
         If enabled, then maximum parallelism will be used determined by
         the number of available CPU cores.
-    use_async : bool, default False

Review comment:
       I added the parameters back in.  PTAL.  One thing I wasn't sure of...
   
   All of the places the parameter was declared it was a `bint` which means I couldn't change the default to `None` which means there was no good way to tell if the user specified it or not.
   
   So I just made the default True and emit the warning if the user specifies `False`.  However, if a user has:
   
   `dataset.to_table(use_async=True)` they will not get the warning.
   
   Alternatively, I could change the cython type from bint to object.  Then I should be able to warn on both `use_async=True` and `use_async=False`.  Would this possible have any backwards compatibility ramifications?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org