[GitHub] [solr] madrob commented on a change in pull request #301: SOLR-15640: Flush / Shutdown Async Loggers and LogManager after a test.

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #301:
URL: https://github.com/apache/solr/pull/301#discussion_r718874914



##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -64,17 +64,6 @@
 @ThreadLeakLingering(linger = 10000)
 public class SolrTestCase extends LuceneTestCase {
 
-  /**
-   * <b>DO NOT REMOVE THIS LOGGER</b>
-   * <p>
-   * For reasons that aren't 100% obvious, the existence of this logger is neccessary to ensure
-   * that the logging framework is properly initialized (even if concrete subclasses do not 
-   * themselves initialize any loggers) so that the async logger threads can be properly shutdown
-   * on completion of the test suite
-   * </p>
-   * @see <a href="https://issues.apache.org/jira/browse/SOLR-14247">SOLR-14247</a>
-   * @see #shutdownLogger
-   */
   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());

Review comment:
       we could also remove the logger too then, right? And check that it doesn't fail in the way Hoss mentioned on SOLR-14247




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org