You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/04/12 00:04:10 UTC
[Bug 4862] New: CONTACT_ADDRESS superseded by rules file downloaded through sa-update
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4862
Summary: CONTACT_ADDRESS superseded by rules file downloaded
through sa-update
Product: Spamassassin
Version: 3.1.1
Platform: Other
OS/Version: NetBSD
Status: NEW
Severity: minor
Priority: P3
Component: sa-update
AssignedTo: dev@spamassassin.apache.org
ReportedBy: klaus.heinz@onlinehome.de
Hi,
after installation of SA 3.1.1 share/spamassassin/10_misc.cf contains:
report_contact postmaster@example.com
Today I tried sa-update for the first time and noticed that the updated
file 10_misc.cf contains
report_contact @@CONTACT_ADDRESS@@
This leads to reports like this:
.. If you have any questions, see @@CONTACT_ADDRESS@@ for details...
I think this setting should probably move from 10_misc.cf to the local.cf
file so it would not be affected by updates.
ciao
Klaus
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4862] CONTACT_ADDRESS superseded by rules file downloaded through sa-update
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4862
------- Additional Comments From radek@pld-linux.org 2006-06-09 17:58 -------
(In reply to comment #1)
> I'm thinking that the install process ought to create a new file in the
> default area, perhaps /usr/share/spamassassin/macros or something, that
> have the mappings.
Administrator might want to edit this file, so placing it in /usr would
violate FHS.
> Or, we just create something like /etc/mail/spamassassin/install.cf
> that sets the macro settings, and then things like sa-update doesn't
> have to worry about it.
That sounds sane... if local.cf is not enough.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4862] [review] CONTACT_ADDRESS superseded by rules file downloaded through sa-update
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4862
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
------- Additional Comments From jm@jmason.org 2006-06-29 09:24 -------
+1 perfect workaround ;)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4862] [review] CONTACT_ADDRESS superseded by rules file downloaded through sa-update
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4862
------- Additional Comments From felicity@apache.org 2006-06-27 06:23 -------
Created an attachment (id=3562)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3562&action=view)
suggested patch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4862] [review] CONTACT_ADDRESS superseded by rules file downloaded through sa-update
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4862
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From felicity@apache.org 2006-07-10 00:10 -------
Sending sa-update.raw
Transmitting file data .
Committed revision 420376.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4862] CONTACT_ADDRESS superseded by rules file downloaded through sa-update
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4862
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.1.4
------- Additional Comments From felicity@apache.org 2006-06-09 16:24 -------
I'm not really sure how we can deal with this yet. The problem being that the @...@ macros are only
handled during the install and the values aren't stored anywhere else. So a kluge would be to parse out
stuff from the installed rule files and then replace values accordingly, but that's horrible and we shouldn't
do it. ;)
I'm thinking that the install process ought to create a new file in the default area, perhaps /usr/share/
spamassassin/macros or something, that have the mappings. Or, we just create something like /etc/
mail/spamassassin/install.cf that sets the macro settings, and then things like sa-update doesn't have to
worry about it.
I don't know, but we should probably do something.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4862] [review] CONTACT_ADDRESS superseded by rules file downloaded through sa-update
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4862
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |can be committed
------- Additional Comments From spamassassin@dostech.ca 2006-07-09 21:54 -------
cool, +1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4862] [review] CONTACT_ADDRESS superseded by rules file downloaded through sa-update
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4862
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|CONTACT_ADDRESS superseded |[review] CONTACT_ADDRESS
|by rules file downloaded |superseded by rules file
|through sa-update |downloaded through sa-update
Status Whiteboard| |needs 2 votes
------- Additional Comments From felicity@apache.org 2006-06-27 06:23 -------
ok, here's the patch ready for 3.1. committed to 3.2:
Sending sa-update.raw
Transmitting file data .
Committed revision 417353.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4862] CONTACT_ADDRESS superseded by rules file downloaded through sa-update
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4862
------- Additional Comments From felicity@apache.org 2006-06-27 05:43 -------
ok, after prodding around I think I came up with a pretty easy fix for this.
sa-update gets preprocessed during install with the variables defined via the
Makefile. Therefore, if we add in macro processing capabilities into sa-update,
and trap the defined variables during install, it should all work fine. I'll
see about working up a patch. :)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.