Re: [PR] [CALCITE-6613] Make the Background code examples in Calcite official documentation clearer [calcite]

["mihaibudiu (via GitHub)" <gi...@apache.org>]

mihaibudiu commented on code in PR #3996:
URL: https://github.com/apache/calcite/pull/3996#discussion_r1811564808


##########
site/_docs/index.md:
##########
@@ -39,8 +39,17 @@ point it at some data.
 
 {% highlight java %}
 public static class HrSchema {
-  public final Employee[] emps = 0;
-  public final Department[] depts = 0;
+public final Employee[] emps = {

Review Comment:
   Is there a test which uses this code?
   This would increase our confidence that the example is good.
   In the past I have discovered that documentation is wrong if there are no tests validating it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org