You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/28 11:32:08 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
rkhachatryan opened a new pull request #13822:
URL: https://github.com/apache/flink/pull/13822
## What is the purpose of the change
Depends on #13821.
The emitted event would allow to tear down "virtual channels" used to read channel state on recovery with unaligned checkpoints and rescaling.
Upstream subpartitions are blocked upon sending this event and unblocked by the downstream when all channels receive it.
## Verifying this change
- Added `ChannelPersistenceITCase.testUpstreamBlocksAfterRecoveringState` to test emission and blocking on the upstream side
- Added `CheckpointedInputGateTest` to test alignment and unblocking on the downstream side
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
}, {
"hash" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544",
"triggerID" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"triggerType" : "PUSH"
}, {
"hash" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545",
"triggerID" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"triggerType" : "PUSH"
}, {
"hash" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e23ce525a7af28103e7abd8547b2ba6c9850567 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545)
* 4409a03053bfbc21bb43df0535e222b17f6dcb51 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #13822:
URL: https://github.com/apache/flink/pull/13822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
}, {
"hash" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544",
"triggerID" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"triggerType" : "PUSH"
}, {
"hash" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545",
"triggerID" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"triggerType" : "PUSH"
}, {
"hash" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8623",
"triggerID" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4409a03053bfbc21bb43df0535e222b17f6dcb51 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8623)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 612c241aa46314c2822a6f350faf3116c1b5cce0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508)
* 54779f8ec9b131efd11662c22d2ff5dcd5cb2a08 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 612c241aa46314c2822a6f350faf3116c1b5cce0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508)
* 54779f8ec9b131efd11662c22d2ff5dcd5cb2a08 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515)
* cecfabd36b9192284b4671fbdf48eb933ffc79e5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 612c241aa46314c2822a6f350faf3116c1b5cce0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508)
* 54779f8ec9b131efd11662c22d2ff5dcd5cb2a08 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515)
* cecfabd36b9192284b4671fbdf48eb933ffc79e5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
}, {
"hash" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544",
"triggerID" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"triggerType" : "PUSH"
}, {
"hash" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545",
"triggerID" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e23ce525a7af28103e7abd8547b2ba6c9850567 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-721145294
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
}, {
"hash" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544",
"triggerID" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"triggerType" : "PUSH"
}, {
"hash" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545",
"triggerID" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"triggerType" : "PUSH"
}, {
"hash" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8623",
"triggerID" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"triggerType" : "PUSH"
}, {
"hash" : "c297b7ca14f26e55649885b0e3efcb4f997533f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8696",
"triggerID" : "c297b7ca14f26e55649885b0e3efcb4f997533f9",
"triggerType" : "PUSH"
}, {
"hash" : "343172c8197162ff4ec4860f0389f6caefdc9ea4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8705",
"triggerID" : "343172c8197162ff4ec4860f0389f6caefdc9ea4",
"triggerType" : "PUSH"
}, {
"hash" : "d14f3c4e3801f5518d6b11586ca655c35c7fef9e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8709",
"triggerID" : "d14f3c4e3801f5518d6b11586ca655c35c7fef9e",
"triggerType" : "PUSH"
}, {
"hash" : "b3ae3549c9c7dd237f7aa84c5daa59f73747668c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8716",
"triggerID" : "b3ae3549c9c7dd237f7aa84c5daa59f73747668c",
"triggerType" : "PUSH"
}, {
"hash" : "7c422adfc89835d7855e985d7cd09ba6202da933",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8799",
"triggerID" : "7c422adfc89835d7855e985d7cd09ba6202da933",
"triggerType" : "PUSH"
}, {
"hash" : "4230a32c598e05d5da143e16489b67aaa66785e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "721145294",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "721145294",
"triggerType" : "MANUAL"
}, {
"hash" : "4230a32c598e05d5da143e16489b67aaa66785e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4230a32c598e05d5da143e16489b67aaa66785e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 4230a32c598e05d5da143e16489b67aaa66785e6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
}, {
"hash" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544",
"triggerID" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cecfabd36b9192284b4671fbdf48eb933ffc79e5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532)
* c121f8a279bb69448c326dab7cee19fd5bb2096c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
}, {
"hash" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544",
"triggerID" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"triggerType" : "PUSH"
}, {
"hash" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545",
"triggerID" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c121f8a279bb69448c326dab7cee19fd5bb2096c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544)
* 6e23ce525a7af28103e7abd8547b2ba6c9850567 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-718471960
Btw there are test failures that seem to be related to the changes.
Also I noticed that you are currently not canceling a checkpoint that occurs in parallel to the recovery (just cancel checkpoint, when `UpstreamRecoveryTracker` is not done yet).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717875371
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1e8d476b327183f27d5d05ef17f31144bdaed00c (Wed Oct 28 11:35:12 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 612c241aa46314c2822a6f350faf3116c1b5cce0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508)
* 54779f8ec9b131efd11662c22d2ff5dcd5cb2a08 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
}, {
"hash" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544",
"triggerID" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"triggerType" : "PUSH"
}, {
"hash" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545",
"triggerID" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"triggerType" : "PUSH"
}, {
"hash" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8623",
"triggerID" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"triggerType" : "PUSH"
}, {
"hash" : "c297b7ca14f26e55649885b0e3efcb4f997533f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8696",
"triggerID" : "c297b7ca14f26e55649885b0e3efcb4f997533f9",
"triggerType" : "PUSH"
}, {
"hash" : "343172c8197162ff4ec4860f0389f6caefdc9ea4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8705",
"triggerID" : "343172c8197162ff4ec4860f0389f6caefdc9ea4",
"triggerType" : "PUSH"
}, {
"hash" : "d14f3c4e3801f5518d6b11586ca655c35c7fef9e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8709",
"triggerID" : "d14f3c4e3801f5518d6b11586ca655c35c7fef9e",
"triggerType" : "PUSH"
}, {
"hash" : "b3ae3549c9c7dd237f7aa84c5daa59f73747668c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8716",
"triggerID" : "b3ae3549c9c7dd237f7aa84c5daa59f73747668c",
"triggerType" : "PUSH"
}, {
"hash" : "7c422adfc89835d7855e985d7cd09ba6202da933",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8799",
"triggerID" : "7c422adfc89835d7855e985d7cd09ba6202da933",
"triggerType" : "PUSH"
}, {
"hash" : "4230a32c598e05d5da143e16489b67aaa66785e6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8901",
"triggerID" : "721145294",
"triggerType" : "MANUAL"
}, {
"hash" : "4230a32c598e05d5da143e16489b67aaa66785e6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8901",
"triggerID" : "4230a32c598e05d5da143e16489b67aaa66785e6",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "721145294",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4230a32c598e05d5da143e16489b67aaa66785e6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8901)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #13822:
URL: https://github.com/apache/flink/pull/13822#discussion_r514073629
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java
##########
@@ -270,7 +271,13 @@
* ALIGNED_EXACTLY_ONCE_CHECKPOINT_BARRIER indicates that this buffer represents a
* serialized checkpoint barrier of aligned exactly-once checkpoint mode.
*/
- ALIGNED_EXACTLY_ONCE_CHECKPOINT_BARRIER(false, true, true, false);
+ ALIGNED_EXACTLY_ONCE_CHECKPOINT_BARRIER(false, true, true, false),
+
+ /**
+ * Indicates that this subpartition state is fully recovered (emitted).
+ * Further data can be consumed after unblocking.
+ */
+ RECOVERY_COMPLETION(false, true, true, false);
Review comment:
We should probably generalize ALIGNED_EXACTLY_ONCE_CHECKPOINT_BARRIER + RECOVERY_COMPLETION to some BLOCKING_EVENT type.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/UpstreamRecoveryTracker.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.partition.consumer.InputGate;
+import org.apache.flink.util.Preconditions;
+
+import java.io.IOException;
+import java.util.HashSet;
+
+final class UpstreamRecoveryTracker {
Review comment:
We should generalize it for all epochs. Not sure if we already do it in this PR or then later.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -263,7 +269,8 @@ BufferAndBacklog pollBuffer() {
buffer = bufferConsumer.build();
- checkState(bufferConsumer.isFinished() || buffers.size() == 1,
+ checkState(bufferConsumer.isFinished() || buffers.size() == 1 ||
Review comment:
Why do we need that change here and not for aligned barriers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
}, {
"hash" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544",
"triggerID" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"triggerType" : "PUSH"
}, {
"hash" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cecfabd36b9192284b4671fbdf48eb933ffc79e5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532)
* c121f8a279bb69448c326dab7cee19fd5bb2096c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544)
* 6e23ce525a7af28103e7abd8547b2ba6c9850567 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
}, {
"hash" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544",
"triggerID" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"triggerType" : "PUSH"
}, {
"hash" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545",
"triggerID" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"triggerType" : "PUSH"
}, {
"hash" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8623",
"triggerID" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e23ce525a7af28103e7abd8547b2ba6c9850567 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545)
* 4409a03053bfbc21bb43df0535e222b17f6dcb51 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8623)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54779f8ec9b131efd11662c22d2ff5dcd5cb2a08 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515)
* cecfabd36b9192284b4671fbdf48eb933ffc79e5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cecfabd36b9192284b4671fbdf48eb933ffc79e5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-720323778
Okay let's proceed as is. Tests are green. Could you rebase and undraft?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 612c241aa46314c2822a6f350faf3116c1b5cce0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13822:
URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8508",
"triggerID" : "612c241aa46314c2822a6f350faf3116c1b5cce0",
"triggerType" : "PUSH"
}, {
"hash" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8515",
"triggerID" : "54779f8ec9b131efd11662c22d2ff5dcd5cb2a08",
"triggerType" : "PUSH"
}, {
"hash" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8532",
"triggerID" : "cecfabd36b9192284b4671fbdf48eb933ffc79e5",
"triggerType" : "PUSH"
}, {
"hash" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8544",
"triggerID" : "c121f8a279bb69448c326dab7cee19fd5bb2096c",
"triggerType" : "PUSH"
}, {
"hash" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8545",
"triggerID" : "6e23ce525a7af28103e7abd8547b2ba6c9850567",
"triggerType" : "PUSH"
}, {
"hash" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8623",
"triggerID" : "4409a03053bfbc21bb43df0535e222b17f6dcb51",
"triggerType" : "PUSH"
}, {
"hash" : "c297b7ca14f26e55649885b0e3efcb4f997533f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8696",
"triggerID" : "c297b7ca14f26e55649885b0e3efcb4f997533f9",
"triggerType" : "PUSH"
}, {
"hash" : "343172c8197162ff4ec4860f0389f6caefdc9ea4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8705",
"triggerID" : "343172c8197162ff4ec4860f0389f6caefdc9ea4",
"triggerType" : "PUSH"
}, {
"hash" : "d14f3c4e3801f5518d6b11586ca655c35c7fef9e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8709",
"triggerID" : "d14f3c4e3801f5518d6b11586ca655c35c7fef9e",
"triggerType" : "PUSH"
}, {
"hash" : "b3ae3549c9c7dd237f7aa84c5daa59f73747668c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8716",
"triggerID" : "b3ae3549c9c7dd237f7aa84c5daa59f73747668c",
"triggerType" : "PUSH"
}, {
"hash" : "7c422adfc89835d7855e985d7cd09ba6202da933",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8799",
"triggerID" : "7c422adfc89835d7855e985d7cd09ba6202da933",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "721145294",
"triggerType" : "MANUAL"
}, {
"hash" : "4230a32c598e05d5da143e16489b67aaa66785e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8901",
"triggerID" : "721145294",
"triggerType" : "MANUAL"
}, {
"hash" : "4230a32c598e05d5da143e16489b67aaa66785e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8901",
"triggerID" : "4230a32c598e05d5da143e16489b67aaa66785e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 4230a32c598e05d5da143e16489b67aaa66785e6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8901)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org