You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/01 08:38:14 UTC
[GitHub] [dolphinscheduler] rockfang opened a new issue, #10730: [Bug] [UI] Workflow Definition. default `environment name` showed wrong when changing `worker group`
rockfang opened a new issue, #10730:
URL: https://github.com/apache/dolphinscheduler/issues/10730
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
in the workflow definition. the default `environment name` showed wrong when changing `worker group`
### What you expected to happen
default `worker group` correctly changed when `environment name` changed
### How to reproduce
1. drag a node in the workflow definition
2. change worker group
### Anything else
it happened when 2 worker groups have the same length environment options.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Amy0104 commented on issue #10730: [Bug] [UI] Workflow Definition. default `environment name` showed wrong when changing `worker group`
Posted by GitBox <gi...@apache.org>.
Amy0104 commented on issue #10730:
URL: https://github.com/apache/dolphinscheduler/issues/10730#issuecomment-1174802436
>
There are three situations.
Firstly, have already created a task with workGroup and environment. WorkGroup and environment should be displayed after data back. For this, we can't set workGroup and environment manually.
Secondly, just want to create a task, then we need to set the default value for workGroup and environment after getting the environmentList.
Thirdly, change the work group and set the default value for environment. For this, I agree with you, it can be handled by using watch, but it should be effect after the component mounted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Amy0104 commented on issue #10730: [Bug] [UI] Workflow Definition. default `environment name` showed wrong when changing `worker group`
Posted by GitBox <gi...@apache.org>.
Amy0104 commented on issue #10730:
URL: https://github.com/apache/dolphinscheduler/issues/10730#issuecomment-1175575717
> @Amy0104 good! I read the code and it works well for me
Thanks for your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] rockfang commented on issue #10730: [Bug] [UI] Workflow Definition. default `environment name` showed wrong when changing `worker group`
Posted by GitBox <gi...@apache.org>.
rockfang commented on issue #10730:
URL: https://github.com/apache/dolphinscheduler/issues/10730#issuecomment-1174891890
@Amy0104 good!
I read the code and it works well for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet closed issue #10730: [Bug] [UI] Workflow Definition. default `environment name` showed wrong when changing `worker group`
Posted by GitBox <gi...@apache.org>.
songjianet closed issue #10730: [Bug] [UI] Workflow Definition. default `environment name` showed wrong when changing `worker group`
URL: https://github.com/apache/dolphinscheduler/issues/10730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Amy0104 commented on issue #10730: [Bug] [UI] Workflow Definition. default `environment name` showed wrong when changing `worker group`
Posted by GitBox <gi...@apache.org>.
Amy0104 commented on issue #10730:
URL: https://github.com/apache/dolphinscheduler/issues/10730#issuecomment-1174852579
I try to fix it. pls check later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] rockfang commented on issue #10730: [Bug] [UI] Workflow Definition. default `environment name` showed wrong when changing `worker group`
Posted by GitBox <gi...@apache.org>.
rockfang commented on issue #10730:
URL: https://github.com/apache/dolphinscheduler/issues/10730#issuecomment-1174834970
Situation A :
manually changed the workGroup selection
> need to set the default environment (null or the default only one)
Situation B:
1. I choose a workGroup like `W`
2. I choose an environment like `W-env`
3. click `save` in this modal. (temp save not submit till now)
4. double click this node to reEdit it (need to redisplay my last choose `W-env)`
What puzzled me is both situation A&B will trigger `watch( () => model.workerGroup...` .
But I can't resolve them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10730: [Bug] [UI] Workflow Definition. default `environment name` showed wrong when changing `worker group`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10730:
URL: https://github.com/apache/dolphinscheduler/issues/10730#issuecomment-1172093001
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] rockfang commented on issue #10730: [Bug] [UI] Workflow Definition. default `environment name` showed wrong when changing `worker group`
Posted by GitBox <gi...@apache.org>.
rockfang commented on issue #10730:
URL: https://github.com/apache/dolphinscheduler/issues/10730#issuecomment-1174790297
> This is a good issue. Do you still want to fix this issue? If you have any problem, you can concat me. I will try to help you. @rockfang
Actually, I didn't find an elegant way to solve it.
here is my logic:
1. When selecting the workGroup just empty the environmentCode.
2. Delete the environmentCode operation in `use-environment-name.ts`. So just pure trigger from workGroup can change the default environmentCode.
3. The `environmentCode ` will not has default. it's ok for me...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Amy0104 commented on issue #10730: [Bug] [UI] Workflow Definition. default `environment name` showed wrong when changing `worker group`
Posted by GitBox <gi...@apache.org>.
Amy0104 commented on issue #10730:
URL: https://github.com/apache/dolphinscheduler/issues/10730#issuecomment-1174774381
This is a good issue. Do you still want to fix this issue? If you have any problem, you can concat me. I will try to help you. @rockfang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org