You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2026/08/01 17:56:24 UTC

[PR] Remove OpenSSL ENGINE code [trafficserver]

JosiahWI opened a new pull request, #13471:
URL: https://github.com/apache/trafficserver/pull/13471

   Commit a966bc4cce (#11219) accidentally disabled OpenSSL ENGINE support entirely. Although it was unintentional, it seems clear no one is using that API by this point (no one has reported it was broken), and the API is gone in recent OpenSSL versions. This patch removes the dead logic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove OpenSSL ENGINE code [trafficserver]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13471:
URL: https://github.com/apache/trafficserver/pull/13471#discussion_r3696242764


##########
src/iocore/net/SSLUtils.cc:
##########
@@ -859,20 +852,6 @@ SSLPrivateKeyHandler(SSL_CTX *ctx, const char *keyPath, const char *secret_data,
   // SSL_CTX_use_PrivateKey() takes its own reference on the key, so this
   // reference must be released on every exit.
   scoped_PKEY pkey;
-#if HAVE_ENGINE_GET_DEFAULT_RSA && HAVE_ENGINE_LOAD_PRIVATE_KEY
-  ENGINE *e = ENGINE_get_default_RSA();
-  if (e != nullptr) {
-    pkey.reset(ENGINE_load_private_key(e, keyPath, nullptr, nullptr));
-    if (pkey) {
-      if (!SSL_CTX_use_PrivateKey(ctx, pkey.get())) {
-        Dbg(dbg_ctl_ssl_load, "failed to load server private key from engine");
-        return false;
-      }
-    }
-  }
-#else
-  void *e = nullptr;
-#endif
   if (pkey == nullptr) {
     scoped_BIO bio(BIO_new_mem_buf(secret_data, secret_data_len));

Review Comment:
   After removing OpenSSL ENGINE support, this function still references `e` later (`if (e == nullptr && !SSL_CTX_check_private_key(ctx))`), but `e` is no longer declared anywhere, which will break the build. The check should now be unconditional.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove OpenSSL ENGINE code [trafficserver]

Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI merged PR #13471:
URL: https://github.com/apache/trafficserver/pull/13471


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove OpenSSL ENGINE code [trafficserver]

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #13471:
URL: https://github.com/apache/trafficserver/pull/13471#issuecomment-5181036220

   Cherry-picked to the 10.2.x branch as f6d818be4f1ff35434fa9611780b825665bfdd22 for the 10.2.0 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org