You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "pepness (via GitHub)" <gi...@apache.org> on 2023/06/25 23:44:13 UTC

[GitHub] [netbeans] pepness commented on pull request #6096: Feature: Added support for Faces 4 changed xmlns namespaces

pepness commented on PR #6096:
URL: https://github.com/apache/netbeans/pull/6096#issuecomment-1606330319

   Hi @asbachb, using GlassFish 7.0.5 and Jakarta EE 10 I test the following:
   - Create a Ant Web App
   - Create a new JSF Page
   - Clean, build and run the web app
   
   Without the PR the namespace is the oracle one:
   ![Screenshot from 2023-06-25 17-13-47](https://github.com/apache/netbeans/assets/9832133/822e1cc9-780d-49fb-ac65-7ab202edccad)
   With the PR the namespace is the Jakarta one:
   ![Screenshot from 2023-06-25 17-14-17](https://github.com/apache/netbeans/assets/9832133/2d2329ad-e439-4d0a-89f5-e5baaf5326d9)
   Auto-completition still works and shows JSF 2.2 (which is correct because it is using `web.jsf20` module)
   ![Screenshot from 2023-06-25 17-09-56](https://github.com/apache/netbeans/assets/9832133/83d6a301-557c-42f8-8a55-3694dfa7c3dc)
   
   
   How do I test `Tag suggestion in faces xhtml editor view` and `Automatic addition of missing namespace declaration when new taglib is used`. Also, I suggest that if possible you upload before/after images or step-to-step instructions to easily review the end result of your PR. Thank's for your hard work.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists