You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/09 15:12:49 UTC

[GitHub] [skywalking-python] Humbertzhang commented on a change in pull request #148: Remove the temporary gRPC log channel

Humbertzhang commented on a change in pull request #148:
URL: https://github.com/apache/skywalking-python/pull/148#discussion_r685256723



##########
File path: skywalking/agent/protocol/__init__.py
##########
@@ -35,5 +35,8 @@ def heartbeat(self):
     def report(self, queue: Queue, block: bool = True):
         raise NotImplementedError()
 
+    def report_log(self, queue: Queue, block: bool = True):
+        raise NotImplementedError()

Review comment:
       Do not raise `NotImplementedError()` here, if user set config.protocol with `http` or `kafka`, it will keep reporting errors!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org