You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/06/10 01:03:45 UTC
[jira] Created: (THRIFT-35) Move language tests into their
appropriate library directory
Move language tests into their appropriate library directory
------------------------------------------------------------
Key: THRIFT-35
URL: https://issues.apache.org/jira/browse/THRIFT-35
Project: Thrift
Issue Type: Improvement
Components: Test Suite
Reporter: Bryan Duxbury
Priority: Minor
It would be cleaner to keep the libraries and test code for each language together under the lib/ directory. It would cut down on duplication of code, make tests easier to run, and unclutter the top of the project a bit.
It's been suggested that if we do this, we should change ALL the languages at once. Does that make this an overly monumental project? Should we make a sub-issue on this issue for every implemented language?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-35) Move language tests into their
appropriate library directory
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603911#action_12603911 ]
Doug Cutting commented on THRIFT-35:
------------------------------------
> Should we make a sub-issue on this issue for every implemented language?
+1. This issue can then be used to track the set.
> Move language tests into their appropriate library directory
> ------------------------------------------------------------
>
> Key: THRIFT-35
> URL: https://issues.apache.org/jira/browse/THRIFT-35
> Project: Thrift
> Issue Type: Improvement
> Components: Test Suite
> Reporter: Bryan Duxbury
> Priority: Minor
>
> It would be cleaner to keep the libraries and test code for each language together under the lib/ directory. It would cut down on duplication of code, make tests easier to run, and unclutter the top of the project a bit.
> It's been suggested that if we do this, we should change ALL the languages at once. Does that make this an overly monumental project? Should we make a sub-issue on this issue for every implemented language?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-35) Move language tests into their
appropriate library directory
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603723#action_12603723 ]
David Reiss commented on THRIFT-35:
-----------------------------------
I think it is fine to do this piecemeal and leave it as one issue.
> Move language tests into their appropriate library directory
> ------------------------------------------------------------
>
> Key: THRIFT-35
> URL: https://issues.apache.org/jira/browse/THRIFT-35
> Project: Thrift
> Issue Type: Improvement
> Components: Test Suite
> Reporter: Bryan Duxbury
> Priority: Minor
>
> It would be cleaner to keep the libraries and test code for each language together under the lib/ directory. It would cut down on duplication of code, make tests easier to run, and unclutter the top of the project a bit.
> It's been suggested that if we do this, we should change ALL the languages at once. Does that make this an overly monumental project? Should we make a sub-issue on this issue for every implemented language?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-35) Move language tests into their
appropriate library directory
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603732#action_12603732 ]
Bryan Duxbury commented on THRIFT-35:
-------------------------------------
We can and should maintain a common test directory at the root still for the thrift files and anything else that might need to be shared.
> Move language tests into their appropriate library directory
> ------------------------------------------------------------
>
> Key: THRIFT-35
> URL: https://issues.apache.org/jira/browse/THRIFT-35
> Project: Thrift
> Issue Type: Improvement
> Components: Test Suite
> Reporter: Bryan Duxbury
> Priority: Minor
>
> It would be cleaner to keep the libraries and test code for each language together under the lib/ directory. It would cut down on duplication of code, make tests easier to run, and unclutter the top of the project a bit.
> It's been suggested that if we do this, we should change ALL the languages at once. Does that make this an overly monumental project? Should we make a sub-issue on this issue for every implemented language?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-35) Move language tests into their
appropriate library directory
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603724#action_12603724 ]
David Reiss commented on THRIFT-35:
-----------------------------------
Oops. I didn't read Mark's email. I stick by my opinion, though. If this gets done over the course of a few weeks, I think it would be fine. One possible difficulty I see is that a lot (all) of the languages use the same .thrift files.
> Move language tests into their appropriate library directory
> ------------------------------------------------------------
>
> Key: THRIFT-35
> URL: https://issues.apache.org/jira/browse/THRIFT-35
> Project: Thrift
> Issue Type: Improvement
> Components: Test Suite
> Reporter: Bryan Duxbury
> Priority: Minor
>
> It would be cleaner to keep the libraries and test code for each language together under the lib/ directory. It would cut down on duplication of code, make tests easier to run, and unclutter the top of the project a bit.
> It's been suggested that if we do this, we should change ALL the languages at once. Does that make this an overly monumental project? Should we make a sub-issue on this issue for every implemented language?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-35) Move language tests into their
appropriate library directory
Posted by "Mark Slee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603737#action_12603737 ]
Mark Slee commented on THRIFT-35:
---------------------------------
Yeah, to clarify, I'm fine with 3 weeks or a month or whatever. I'm not saying it should all be in one commit. But this is the kind of task that's easy to start in on and then end up 1 year later with test files in different locations.
> Move language tests into their appropriate library directory
> ------------------------------------------------------------
>
> Key: THRIFT-35
> URL: https://issues.apache.org/jira/browse/THRIFT-35
> Project: Thrift
> Issue Type: Improvement
> Components: Test Suite
> Reporter: Bryan Duxbury
> Priority: Minor
>
> It would be cleaner to keep the libraries and test code for each language together under the lib/ directory. It would cut down on duplication of code, make tests easier to run, and unclutter the top of the project a bit.
> It's been suggested that if we do this, we should change ALL the languages at once. Does that make this an overly monumental project? Should we make a sub-issue on this issue for every implemented language?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.