[GitHub] dpa99c commented on issue #339: Share code between ios CDVWKInAppBrowser and CDVUIInaAppBrowser

[GitBox <gi...@apache.org>]

dpa99c commented on issue #339: Share code between ios CDVWKInAppBrowser and CDVUIInaAppBrowser
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/339#issuecomment-435106728
 
 
   In principle I agree, and my original intention when creating the WKWebView implementation was to do this. In fact I began by attempting to have a common base class from which the two implementations inherited. However, it quickly became clear to me that class inheritance in Objective C is a messy business and I found I was spending more time on the inheritance issues than the actual new WKWebView implementation, hence I decided for brevity to go with the separate implementations which contain duplicity. Also in the back of my mind is that UIWebView is deprecated and may well be removed in a future iOS release, so the effort of an inheritance strategy may be wasted effort.
   
   Having said that, I'm sure if you were to submit a PR which implemented such an inheritance strategy that it would be accepted and merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org